Gratuities/Tips?

I have thoughts on a few different scenarios.

1. Customer pays cash $20 on a $15 order. Cashier enters $20 and POS has an option to add a gratuity rather than expect the whole $5 to be given as change.
2. Customer pays debit or credit $20 on a $15 order because they added $5 on the terminal. Cashier enters $20 debit and POS prompts to record the difference as a gratuity.
3. Customer pays debit or credit with gratuity on a semi-integrated terminal. The terminal submodule automatically adds the gratuity to the order.
4. Assuming any other (non-Paymentree**) integration also identifies that part of a sale was a gratuity.

Maybe finishing an order would require either the total owing to be $0 or if negative, for there to be enough total cash payments to give change back. Otherwise you'd have to resolve the difference by recording a gratuity or fixing a mistake you made in the payment amounts you entered.

Gratuities seem like they'd make a pretty simple line item type we could add to the order.

** The Paymentree module doesn't support tips but Paymentree will return that information so we could add support to commerce_pos_terminal and commerce_paymentree.

I was already half-way through this when @travis-bradbury suggested we take a different approach and add a way for the commerce_pos_terminal module to add gratuities for debit/credit cards, and have an apply change button for tips if they pay in cash.

To expand on that - there's two ways to pay with credit/debit. One involves the terminal submodule and a semi-integrated payment terminal. The POS and the terminal would communicate, allowing us to automatically know that a gratuity was added.

Without that sub-module you're just using payment methods from commerce_cop to say you took a credit or debit payment. That couldn't involve commerce_pos_terminal since it's probably not even installed.

Get this error if i try to pay without setting up a payment gateway, edge case i know, but shouldn't error.

Also I lose the gratuity option once I hit pay but before I hit finish, it would be really nice if I could still add it then? I dunno if that might be difficult with totals and such, but it would be really nice to add a gratuity later in the flow, since you likely won't know that until the customer pays.

Otherwise functionality seems to work just fine for me. It would be nice to have a gratuities report, but that probably warrants it's own issue.

Here's the solution Shawn and I came up with.

Gratuity button that would function similarly to the Discount button. But should only be on the Pay page.

Tip icon (coffee cup) that will immediately apply the change as a gratuity.

Yes, this patch is specific to manual tips and doesn't handle integration with a payment terminal, which will probably be handled in a totally separate issue.

almost everything looks good, one issue with the max gratuity though.

the logic for validating when clicking the 'add as gratuity' button was broken (see gifs).

i fixed that logic, though im not sure why there are two separate spots for the validation. and strangely, if you open up the hidden gratuity menu but then click the 'add as gratuity' button, both validations get called for some reason ( i assume bcuz something is submitting both buttons)

ah stupid sass change got in

Initial review from Jacer finished, flipping this back to needs work now for the last of the graphical changes

Rerolled patch against newest dev

Styling on the gratuity buttons and form is off, compare with the mockup jason did, buttons and text box are wrong sizes. Otherwise everything seems good.

Tested with re-rolled patch in chrome and ff on ubuntu and in edge and chrome on windows 10 and get same display as my previous screenshot. Are you sure the right changes are getting bundled into your patch?

Looking over the patch, The only sass change I see is a single margin change, nothing else. Also, your patch is actually 8 separate patches, looks like you're generating a patch for each commit instead of the more standard "all in one" patch.

Slight reroll as patch didn't apply against newest master.

Did a bit of CSS cleanup. New patch attached.

• Added hover state on blue buttons to match others.
• Made the heights of the buttons consistent.
• Cleared float after the buttons so they didn't go over elements below.
• Adjusted styles a bit to match design better.

Boom! Merged this baby in! Thanks to everyone who helped build this functionality, with special thanks to wildkatana who did the bulk of the work. Great job!