Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lpeabody created an issue. See original summary.

The last submitted patch, 2: video_embed_field-video-id-twig-function-2857432-2.patch, failed testing.

The last submitted patch, 2: video_embed_field-video-id-twig-function-2857432-2.patch, failed testing.

The last submitted patch, 2: video_embed_field-video-id-twig-function-2857432-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: video_embed_field-video-id-twig-function-2857432-3.patch, failed testing.

Sam152’s picture

Version: 8.x-1.3 » 8.x-1.x-dev
Issue tags: +Needs tests

NW for a patch that applies. Also this needs tests. I'm not convinced this is a common requirement, can you elaborate on your use case?

RgnYLDZ’s picture

I have a similar need wich might be an example case;

I want to display the thumbnail and the embedded video the same time so I can use them in a twig template.

I basically will hide the video and fade it in screen when user clicks on the thumbnail.

So in this case we'll need both of them ready in dom.

Sam152’s picture

Status: Needs work » Closed (won't fix)

With the advent of Media in core, the Video Embed Field module has moved to being minimally maintained. Only issues which assist in the migration to Media in core will be committed. To read more about this decision, please see: #3089599: Maintenance status for Video Embed Field now that media is in core.

srdtwc’s picture

Here us an updated patch with Drupal 10 compatibility

srdtwc’s picture

Previous patch was missing blank line at end of file. I believe this one should work.