Hi everyone,
Since the commit of this morning, PHPCS doesn't apply filter `--extension`.
Indeed, it checks any file, (Yml, .module, .info ...etc).
Moreover, I got new issues like "Data types in @var tags need to be fully namespaced". Why fully namespace is now required ? A use statement is there for that.

Regards,

Comments

RoyRoger created an issue. See original summary.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Category: Bug report » Support request
Status: Active » Fixed

The --extension option merges with what is configured in Drupal's ruleset.xml. If you want to ignore certain files then you need to use the --ignore option:

phpcs --standard=Drupal --ignore=*.yml

Fully qualified data types:

Always prefix types with the fully-qualified namespace for classes and interfaces (beginning with a backslash).

From https://www.drupal.org/docs/develop/coding-standards/api-documentation-a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Shiraz Dindar’s picture

Shiraz Dindar
Location Sooke, BC
CreditAttribution: Shiraz Dindar commented

But is this desirable behaviour? If this is the way it's going to be, then the documentation here needs to be updated: https://www.drupal.org/node/1587138

Totally threw me for a loop.

Shiraz Dindar’s picture

Shiraz Dindar
Location Sooke, BC
CreditAttribution: Shiraz Dindar commented

Also, just noting that the ruleset commit is here: http://cgit.drupalcode.org/coder/commit/?id=3342de51a9c35179c6c8a0e35b39...

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented

right, opened #2862837: Update docs page for file extensions and how to exclude certain extensions.