It shows two screenshots from Bootstrap for a width below 768px in D8 and D7.
You see in the drupal-8 version that the site_logo is almost touching the border.
In drupal-7 from drupal-bootstap.org site it is displayed correctly.

In D7 you got the class '.navbar .logo' with the attribute 'padding-left: 15px' which negates the attribute 'margin-left: -15px' effect from 'navbar-header' if the width is smaller 768px.

In D8 something similar is missing, and I think that is why the site_logo is so far left.

CommentFileSizeAuthor
#10 interdiff-2857303-9-10.txt2.3 KBmarkhalliwell
#10 navbar_site_logo_is-2857303-10.patch2.88 KBmarkhalliwell
#9 interdiff-2857303-7-9.txt1.02 KBnjagojevic
#9 navbar_site_logo_is-2857303-9.patch1.83 KBnjagojevic
#7 navbar_site_logo_is-2857303-7.patch1.7 KBnjagojevic
#7 interdiff-2857303-5-7.txt1.62 KBnjagojevic
#5 navbar_site_logo_is-2857303-5.patch881 bytesnjagojevic
#3 navbar_site_logo_is-2857303-3.patch4.55 MBnjagojevic
drupal-7-on-drupal-bootstrap.org_.png18.71 KBmvogel
drupal-8.png8.21 KBmvogel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mvogel created an issue. See original summary.

rudraram’s picture

rudraram CreditAttribution: rudraram at Axelerant commented

D8 is missing the Bootstrap style overrides which are present in D7.

njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented
Assigned: Unassigned » njagojevic
Status: Active » Needs review
FileSize
navbar_site_logo_is-2857303-3.patch4.55 MB

Provided patch which fixes this issue.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Needs review » Needs work

Please only change the source files:

http://cgit.drupalcode.org/bootstrap/tree/starterkits/less/less/componen...
http://cgit.drupalcode.org/bootstrap/tree/starterkits/sass/scss/componen...

The code in the CSS folder is automatically compiled on commit by maintainers:
https://drupal-bootstrap.org/api/bootstrap/docs%21Maintainers.md/group/m...

njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented
Status: Needs work » Needs review
FileSize
navbar_site_logo_is-2857303-5.patch881 bytes

New patch with changes in Sass and Less files which are not compiled.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Needs review » Needs work
Related issues: +#2652098: User menu links not shown properly on Static Fixed Top Nav bar, +#2251919: Navbar module integration

We really shouldn't be targeting the mobile media query as this uses max-width.

Any solution made should be mobile first.

That being said, this is the relevant 7.x-3.x code that the OP mentions:
http://cgit.drupalcode.org/bootstrap/tree/starterkits/less/less/override...

njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented
Status: Needs work » Needs review
FileSize
interdiff-2857303-5-7.txt1.62 KB
navbar_site_logo_is-2857303-7.patch1.7 KB

As far as I can understand, this should be a mobile first solution.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Needs review » Needs work

It should match what is currently being done in the 7.x-3.x branch as I said in #6.

njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented
Status: Needs work » Needs review
FileSize
navbar_site_logo_is-2857303-9.patch1.83 KB
interdiff-2857303-7-9.txt1.02 KB
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Assigned: njagojevic » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
navbar_site_logo_is-2857303-10.patch2.88 KB
interdiff-2857303-9-10.txt2.3 KB

Some minor corrections.

  • markcarver committed 3344258 on 8.x-3.x authored by njagojevic 
    Issue #2857303 by njagojevic, markcarver, mvogel: Navbar site_logo is...
  • markcarver committed 55ff7e4 on 8.x-3.x
    Automated commit: grunt compile (CSS)

Issue #2857303 by njagojevic,...
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Reviewed & tested by the community » Fixed
njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented

Thanks for the help @markcarver.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.