CommentFileSizeAuthor
#5 replace_deprecated_uses-2857045-5.patch9.36 KBporchlight
#4 entitymanager.txt818 bytesPavan B S
#4 menu_position-replace_deprecated_uses-2857045-4.patch9.38 KBPavan B S
#2 menu_position-replace_deprecated_uses-2857045-2.patch8.49 KBbkhandruk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rocket.man created an issue. See original summary.

bkhandruk’s picture

bkhandruk CreditAttribution: bkhandruk commented
Assigned: bkhandruk » Unassigned
Status: Active » Needs review
FileSize
menu_position-replace_deprecated_uses-2857045-2.patch8.49 KB

Replaced deprecated uses in module.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Assigned: Unassigned » Pavan B S
Status: Needs review » Needs work

Thanks for the patch, but i still found 2 instances of EntityManager.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Assigned: Pavan B S » Unassigned
Status: Needs work » Needs review
FileSize
menu_position-replace_deprecated_uses-2857045-4.patch9.38 KB
entitymanager.txt818 bytes

Applying the patch, please review.

porchlight’s picture

porchlight CreditAttribution: porchlight as a volunteer and at Northern Commerce commented
FileSize
replace_deprecated_uses-2857045-5.patch9.36 KB

Patch didn't apply for me, had to re-roll.

amit.drupal’s picture

amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs review » Reviewed & tested by the community

Thanks @porchlight for good patch

Code looks good, patch applies cleanly and runs without throwing any errors.
I think we're good to RTBC this but if anyone else comes across this please do give it a once over as well.

  • BarisW committed 68bef84 on 8.x-1.x authored by porchlight 
    Issue #2857045 by Pavan B S, rocket.man, porchlight: Replace deprecated...
BarisW’s picture

BarisW CreditAttribution: BarisW at LimoenGroen for Historisch Centrum Overijssel commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.