The menu "Workbench" at the "Toolbar" does not hide when the user doesn't have permission to access the workbench. I have attached the screenshots below.

Permission Page:
site image

Login Page:
site image

CommentFileSizeAuthor
#8 perm-typo-2856536-8.patch423 bytesnatemow
#5 interdiff-2856536-2--2856536-5.txt413 bytesaczietlow
#5 workbench_toolbar-2856536-5.patch1.64 KBaczietlow
#2 workbench_toolbar-2856536-2.patch1.64 KBaczietlow
site.PNG13.89 KBAnishnirmal
siteadmin login.PNG8.66 KBAnishnirmal
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anishnirmal created an issue. See original summary.

aczietlow’s picture

aczietlow CreditAttribution: aczietlow as a volunteer commented
FileSize
workbench_toolbar-2856536-2.patch1.64 KB

I've wrapped the toolbar menu item in an access check to only render the menu item if a user has permission to view my workbench.

aczietlow’s picture

aczietlow CreditAttribution: aczietlow as a volunteer commented
Status: Active » Needs review
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
Status: Needs review » Needs work

Permission strings should be all lower case, otherwise looks good.

Thanks.

aczietlow’s picture

aczietlow CreditAttribution: aczietlow as a volunteer commented
Status: Needs work » Needs review
FileSize
workbench_toolbar-2856536-5.patch1.64 KB
interdiff-2856536-2--2856536-5.txt413 bytes

Good catch.

  • agentrickard authored 577da27 on 8.x-1.x 
    Merge pull request #7 from agentrickard/toolbar

Issue #2856536 by...
  • agentrickard committed 82690be on 8.x-1.x authored by aczietlow
    Issue #2856536 by aczietlow, Anishnirmal: "Workbench" toolbar menu not...
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
Status: Needs review » Fixed

Committed to github and drupal.org.

natemow’s picture

natemow CreditAttribution: natemow commented
Version: 8.x-1.0-alpha2 » 8.x-1.0-alpha3
Status: Fixed » Patch (to be ported)
FileSize
perm-typo-2856536-8.patch423 bytes

Looks like there was a typo in the perm string in workbench_toolbar(); attached patch fixes that.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented

Sigh. Thanks

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
Status: Patch (to be ported) » Fixed

Rolling alpha4.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented