Missing argument 3 for _editor_advanced_link_attributes_validate() in _editor_advanced_link_attributes_validate() [#2856342]

This might be an easy fix, but I'm seeing this when opening the link popup and making a link.

Warning: Missing argument 3 for _editor_advanced_link_attributes_validate() in _editor_advanced_link_attributes_validate()

Comment	File	Size	Author
#6	editor_advanced_link-missing-argument-2856342-6.patch	675 bytes	weseze
#6
#4	editor_advanced_link-missing-argument-2856342-4.patch	673 bytes	myLies
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 27 February 2017 at 15:10

vilepickle created an issue. See original summary.

Comment #2

Anonymous (not verified) CreditAttribution: Anonymous commented 27 February 2017 at 15:12

Version:

8.x-1.x-dev

» 8.x-1.3

It looks like this may have already been fixed in dev...

Comment #3

Paul Dudink CreditAttribution: Paul Dudink commented 13 March 2017 at 17:38

I haven't checked whether or not this issue has been fixed, however I have been looking at the code and the "issue" is still there in the dev code:
The third parameter is $form, but $form is not being used in the function, so why is there in the first place?
The parameter should be removed.

Comment #4

myLies CreditAttribution: myLies as a volunteer commented 14 March 2017 at 10:47

Status:

Active

» Needs review

File	Size
editor_advanced_link-missing-argument-2856342-4.patch	673 bytes

@vrijdenker - you are right, form validation\submit callback should have same hook_form_alter parameters
attached patch should fix it

Comment #5

Paul Dudink CreditAttribution: Paul Dudink commented 15 March 2017 at 12:22

I'm sorry I have to take back my last comment. I may have been looking at old code, since I just switched to the dev-branch and the third parameter is gone after all. So indeed the bug has been fixed in the dev-branch.

@myLies: I'm not sure whether your patch should be applied or not. The bug as mentioned by @vilepickle has been fixed after all.