[D8] Quora - Related Questions / Posts

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectquoragit

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please follow the usual ways to deal with abandoned projects: https://www.drupal.org/node/251466

Manual review:

1) Some style violations:

$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md .

FILE: quora/quora.module
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
3 | ERROR | [ ] Missing short description in doc comment
7 | ERROR | [x] There must be one blank line after the last USE
| | statement; 0 found;
11 | ERROR | [x] Expected 1 blank line before function; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: quora/README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
36 | WARNING | Line exceeds 80 characters; contains 104 characters
40 | WARNING | Line exceeds 80 characters; contains 84 characters
----------------------------------------------------------------------

FILE: quora/src/Form/QuoraConfigForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
80 | WARNING | NodeType::loadMultiple calls should be avoided in
| | classes, use dependency injection instead
113 | WARNING | NodeType::loadMultiple calls should be avoided in
| | classes, use dependency injection instead
----------------------------------------------------------------------

FILE: quora/src/Plugin/Block/QuoraContent.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
29 | ERROR | Missing short description in doc comment
159 | WARNING | t() calls should be avoided in classes, use
| | dependency injection and $this->t() instead

----------------------------------------------------------------------

2) bad style:

    $gs_results = json_decode(@file_get_contents('https://www.googleapis.com/customsearch/v1?key=' . $api . '&cx=' . $cx . '&q=' . urlencode($query)));

same goes for

  $gs_results = json_decode(@file_get_contents('http://ajax.googleapis.com/ajax/services/search/web?v=1.0&rsz=large&q=' . urlencode($query)));

- Don't just fail silently without any logging or errors!
- Don't try to incorporate http calls using file_get_contents - please use guzzle instead. https://www.acquia.com/de/blog/5-php-components-every-drupal-8-developer...

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.