Fix coding standards [#2856180]

Comment	File	Size	Author
#2	coding-2856180-2.patch	4.89 KB	Pavan B S

	userrestriction.png	197.17 KB	Pavan B S

Comment #1

27 February 2017 at 06:06

Pavan B S created an issue. See original summary.

Log in or register to post comments

Comment #2

Pavan B S CreditAttribution: Pavan B S at Valuebound commented 27 February 2017 at 06:10

Assigned:	Pavan B S	» Unassigned
Status:	Active	» Needs review

File	Size
coding-2856180-2.patch	4.89 KB

Applying the patch, please check.

Log in or register to post comments

Comment #3

riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented 28 February 2017 at 17:41

Status:

Needs review

» Reviewed & tested by the community

@pavan B S, thanks for solving coding standard issue, it works well.

Log in or register to post comments

Comment #5

snufkin CreditAttribution: snufkin commented 5 March 2017 at 20:32

Status:

Reviewed & tested by the community

» Fixed

Looks good, fixed, thanks!

Log in or register to post comments

Comment #6

riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented 6 March 2017 at 05:59

@Pavan B S, I guess you forgot to provide me RTBC credit, can you please do the needful.

Log in or register to post comments

Comment #7

Pavan B S CreditAttribution: Pavan B S at Valuebound commented 6 March 2017 at 06:30

@Jigar.addweb I'm not maintainer of this module, i think @snufkin can do that.

Log in or register to post comments

Comment #8

riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented 6 March 2017 at 07:48

Oh .. sorry, my mistake.
@snufkin, Can you please do the needful to providing me RTBC Credit.

Log in or register to post comments

Comment #9

snufkin CreditAttribution: snufkin commented 14 March 2017 at 10:58

I'm not sure what you mean by RTBC credit. As the patch is authored by Pavan, he gets the credit for fixing the issue.

Log in or register to post comments

Comment #10

riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented 14 March 2017 at 13:18

@snufkin, i provide you one document for drupal credits
https://www.drupal.org/drupalorg/blog/a-guide-to-issue-credits-and-the-d... , please refer this link & let me know if i'm wrong regarding RTBC Credit.

Log in or register to post comments

Comment #11

snufkin CreditAttribution: snufkin commented 16 March 2017 at 09:49

Status:

Fixed

» Active

Log in or register to post comments

Comment #12

snufkin CreditAttribution: snufkin commented 16 March 2017 at 09:50

Status:

Active

» Fixed

Log in or register to post comments

Comment #13

snufkin CreditAttribution: snufkin commented 16 March 2017 at 09:53

To me it looks like only you can credit your contribution (see https://www.drupal.org/node/2451283), I can't do that for you. For the commit and the code Pavan got the credit. Next time if you review make sure to check the attribute this contribution portion.