[Roadmap] Layout Plugin to Layout Discovery on Drupal 8.3 and beyond

Done a fair search and I cannot find what a BC layer is! Would you mind briefly explaining. Thanks

@Mark F ... BC is a drupalism for backward compatibility.

April 7, experimenting with 8.3 on my local system. AT:
# Information added by Drupal.org packaging script on 2017-03-07
version: '8.x-2.0+5-dev'

IF I disable the layout plugin module and install the layout discovery and field layout modules that come as experimental in 8.3, I then can't install AT because it wants the layout plugin module.

if I try to run both layout discovery and layout plugins I get:
Cannot use object of type Drupal\Core\Layout\LayoutDefinition as array in D:\webpage\drupal8\modules\layout_plugin\src\Plugin\Layout\LayoutPluginManager.php on line 162

I have to delete the layout plugin module completely from my modules directory to get rid of the above message. I suspect there is some poison between layout discovery and the layout plugin. I can't find a way to disable the layout discovery and don't want to just delete it since it comes with 8.3 core.

So, with 8.3 how do we proceed with AdaptiveTheme?

I am also facing same error. It seems that the problem is with layout_plugin module not with theme, as my theme is seven which is default theme of drupal.

Facing an issue with Drupal 8.3.0

I think layout_plugin and layout_discovery (core module) doesn't work together.
My solution to create a subtheme was to enable layout_plugin without enabling layout_discovery, and installed at_tools.
I created the adaptivetheme subtheme, then i disable at_tools and layout_plugin and enable layout_discovery.

Per https://www.drupal.org/node/2867795 layout plugin and layout discovery don't work together. Fortunately I found that out on my local test system, which is basically a throwaway. Also, on the test system, once I had layout discovery enabled I was unable to disable it again. I didn't want to delete it entirely from my core/modules directory. I don't want to try on my "production" system. There, I am just leaving all the stuff (AT and layout plugin and layout discovery and the layout fields) off until more skillful people can reach a resolution. I think, at some point we'll need a version of AT that works with the "experimental" core programs rather than the layout plugin.

@Liakoni

I created the adaptivetheme subtheme, then i disable at_tools and layout_plugin and enable layout_discovery.

that's an interesting idea. Now that you have layout discovery enabled is the check box to disable it available? Once I had it enabled on my test system there was no way I could turn it off.

yes, you are right. layout plugin and layout discovery don't work together. I was using layout plugin to create a panel page. Plugin was throwing an error and not allow user to go next page where we select layout of panel. I have disable the layout discovery and layout plugin work fine for me. Thanks.

Sorry if this is the wrong place for this, but I cannot seem to update to 8.3 because we use AT with DS and I cannot seem to turn off layout plugin. Has anyone gotten around this? In some way fixed, replaced or removed layout plugin? All our sites are AT, so the inability to update is worrying... :(

@justkristen Can you give some more details? Is the database not responding to the attempt to uninstall the Layout module or does turning off the Layout module cause other things to break?

@justkristen: manually update both Drupal to 8.3.1 and DS to 8.x-3.0-beta3 (manually means replace the files yourself, don't use in site update tool). Then, use "/update.php" which will manage to disable older layout module and enable newer one.

I tried to update a site with #10 comment instructions, but the theme doesn't work. I don't have css for the adaptivetheme subtheme. If i change the theme and there is no problem.

I provide a screenshot for the site.

@Liakoni: comment #10 is just an easy way about switching the layout modules. Regarding your comment #11, as I've made this misktake, be aware that Drupal root 'themes' folder might have been erased by copying Drupal update files so is AdaptiveTheme. Check that "/themes/adaptivetheme/at-core" folder is still there.

The themes folder wasn's erased and the "/themes/adaptivetheme/at-core" folder was still there. But the problem was with the module field_layout. I installed it and this crashed the theme. When i disable it the theme appeared .

PhilY - That made the home page (which doesn't exist) and the admin pages show up, but none of the actually themed pages show up now, and I get the same error.

I don't have field_layout installed, either. Still not working after #10. Still
Error: Cannot use object of type Drupal\\Core\\Layout\\LayoutDefinition errors? My brain isn't big enough, and our site is quite a way toward being built out that re-doing it seems silly, but at the same time, we can't put off updating indefinitely... Please, can anyone offer help to a bear of very little brain?

I've opened #2879530: Notes re updating themes to AT 8.x-1.0 as a place to compare notes and tips for updating AT themes to Drupal 8.3.x.

Hi all,

I'm trying to enable Panels (+ Page Manager, etc) on Drupal 8.3.2 with AT Tools/Generator 8.x-2.0.

Problem is that AT requires the "Layout Plugin" and Panels 8.x-4.1 needs "Layout Discovery". As some of you have noticed those two are incompatible.

The only workaround I see is what @Liakoni explains in #5 - disabling AT Tools, Layout plugin and enabling Layout Discovery but will everything work as expected?

What other options do I have? Any ideas when AT will have support for Layout Discovery? Any other similar themes that are compatible with the current versions of Drupal and Panels?

Thanks,

This explains the current issue at hand.

I suggest reading the full thread as it explains why AT may be on a waiting pattern.

https://www.drupal.org/node/2811175

As for my projects, I am holding on 8.2 until there is more clarity.

I was faced with the same problems but stumbled upon the problem when trying to install Display Suite. That module requires the latest build when you are on Drupal 8.3 "due to core changes in 8.3". This requires to have Layout Discovery enabled which is still an experimental module. Since that experimental module is incompatible with the layout plugin I had to make a hard choice ...Since I am on Drupal 8.3 and needed Display Suite installed I disabled at tools, at theme generator and layout plugin and enabled layout_discovery. I had no problem to install Display Suite and since I already had created my subtheme I wasn´t to worried.

But I was so stupid to think I could out smart everything and started to enable at tools, at theme generator and layout plugin. That gave me the "The website encountered an unexpected error. Please try again later." error. No more login ... nothing.

Luckily Drush saved me: uninstalling at tools, at theme generator and layout plugin followed by a cache rebuild with Drush got me back on my feet.

The only warning I get is at the subtheme settings page: "Please install the AT Tools module for Drupal 8. Your theme may not operate correctly without this module installed." But I can live with that for the time being.

Edit: although I had everything working at first glance, I ran into the 'The website encountered an unexpected error. Please try again later." error again when I tried to access a node although the rest worked fine. I had to ask my host company to restore a backup since I neglected to make one this month ...

And all this because of an experimental module in drupal !!!

Bwolf, we are waiting as well, and we have most of our sites built using AT and DS. :/

AT themes is one of the only themes/modules that still rely on the contrib module. All the other modules/themes are already switched. So yeah if you rely on AT you're stuck on drupal 8.2 for a while.

I'm afraid so...

. So yeah if you rely on AT you're stuck on drupal 8.2 for a while.

Problem is that when the author of the contrib theme just stops responding to issues there is absolutely no telling what "a while" means. It could == forever. Yet on the theme home page it still shows as actively supported. Not.

Up

Hi all,

Independent of work on Adaptivetheme itself, it appears likely that custom themes built for a previous version will need some upgrade work.

I earlier mentioned I'd outlined upgrade steps that appeared to work for me in #2879530: Notes re updating themes to AT 8.x-1.0. AFAIK, these steps don't need to wait on a new release of Adaptivetheme.

Have people tried to follow these steps? If so, have they hit problems? What problems?

Sharing tips, detailing experience, and following up in #2879530 could help channel frustration in a productive direction.

Another possible step, of course, might be to sponsor development work, or to coordinate an effort to pool funds toward that aim.

Thanks.

@fkelly I have send a PM to Jeff to see what´s up and suggested that, in case he is swamped with paid work, would update the project page to seek a co-maintainer ...After all AT is one of the best, if not the best, themes on Drupal ... With +60 K sites using I´d hate to see it going into oblivion ... i just went through 190 D8 themes and none come close to AT in terms of docs, the ease of creating a sub theme, use a custom css file, having a mobile ready nav (hamburger menu) out of the box etc, ridiculous easy to create additional regions ...

Even if this ridiculous problem about drupal forcing a theme and modules using an experimental module never get´s solved with AT, I´m too far on my project to mess around with another theme and manually alter the code (sub theme, custom css, additional module for mobile nav ....) ... This means also that since D6 I will ditch Display Suit and/or Panels since those modules adhered to the ridiculous Drupal policy that for D8.3.3 the code needs to be altered to use the experimental module ...

@dzinelabs ... thanks, and I appreciate your recommendation on the Adaptivetheme. I had spent probably a two months elapsed time and a week or two actual time before 8.3 hit and blew things apart. I was just experimenting at the localhost (test site) level because I hadn't come up with a color scheme that my wife (my chief client) would accept. I am currently experimenting with the dw3css theme, which also looks very promising and even easier to "colorize".
@nedjo ... I commented in your thread and expressed my appreciation for your efforts. It is a bit of a stretch for me to put that level of effort in, especially since, if the theme author gets to updating the theme those steps will have to be thrown away.

This is a slight bummer. I recently (last month) started my first Drupal 8 project after a few years of not using Drupal, and instinctively kicked it off with AT, which I used for many Drupal 7 projects.

I am super impressed with how slick AT8 is, but encountered the Layout Discovery / Layout Options compatibility issue as soon as I started looking to use Display Suite for custom content layouts.

I think I'll persevere with AT, since I'm already so familiar with it and challenge myself to make things work / look good without DS!

Hopefully this turns out well for you Jeff.

I have the same problem and sentiments. AdaptiveThemes I've been using almost exclusively.... now with D8.3.x... it's fubar'd.

Any help on this issue is appreciated. Apologies if posted in incorrect place. I want to use D8 but will have to drop back to D7 immeidately if no workarounds or fixes are released in the next couple days.....

Edit reason: It's simply because there is no 8.3 version. My mistake for any indication it was because of other modules.
Any adivice as to if I am incorrect, would be greatly appreciated. Most appreciated, Jeff Burns.

Hi Jeff

The Issue for me was AT tools and 8.3

Following these steps got me a working sub-theme of AT 8.x-2.x on Drupal core 8.3.x:

• Install Drupal core 8.3.6. Optional: enable the Layout Discovery module.
• Optional: install Display Suite 8.x-3.x.
• Patch the dev release of AT 8.x-2.x with the patch from #2876818-11: Cannot use object of type Drupal\Core\Layout\LayoutDefinition as array and then install it.
• Download the dev release of AT Tools 8-x-2.x. Edit the .info.yml file to remove the dependency on layout_plugin (see #2875755: remove dependency on layout_plugin for drupal 8.3.x).
• Enable AT Tools and follow the instructions to generate a theme.

In sum: with a couple of simple patches, everything seems to be working nicely.

Jeff Burnz - Definitely upgrading. Our problem is entirely with current live installs. Not one of them has upgraded well at all.

For me see #20 in this thread and my comments in the DS issue que: https://www.drupal.org/node/2885289

This issue seems to become a ping pong game.. DS seems to point the finger to AT... AT now seems to say it's not at all a mere theme issue.. I. O. W that AT is up to the Drupal change... And although the solution nedjo provided may work... Fiddling with patches to just humour an experimental D8 module is just plain ridiculous.. But as far as I can understand from the DS issue cue : Almost any module that does something with layouts must change it's dependency per drupal 8.3.

If you use multiple modules that do somethings with layouts (in your example: display-suite + Adaptive Theme, other had display-suite + panels + bootstrap_layouts) you must be very careful before upgrading. This will probably smooth out in time.
Regarding upgrade-path; you should only upgrade layout-related modules that have either a dependency on Layout Discovery (drupal 8.3+) or contrib Layout Plugin. And don't mix 'm up unless you are very sure it works.

So it's a pickle since my tiny brain gets a report to upgrade Drupal but those who develop modules/themes not always are up to speed to change the dependency... Anyhow ending my rant.... AT and Ds at this time does not play together (unless one is willing to go to the patch road)...

I installed AT 8.x-2.0 with AT Tools and AT Theme Generator which require Layout Plugin on a Drupal 8.3.6 site, then wanted to install Panelizer and Panels which require Layout Discovery and got the aforementioned

“Layout Discovery cannot be installed because the Layout Plugin module is installed and incompatible.”

message. Since I had already created my subtheme, I uninstalled AT Tools, AT Theme Generator and Layout Plugin, then installed Panelizer, Panels and Layout Discovery. Checking “Appearance”, I was dutifully warned

“Please install the AT Tools module for Drupal 8. Your theme may not operate correctly without this module installed.”

Sure enough, on going to any pages other than my home page or admin themed pages I got

“Fatal error: Cannot use object of type Drupal\Core\Layout\LayoutDefinition as array in mysiteroot\themes\adaptivetheme\at_core\includes\misc.inc on line 106”

Just in case anyone is curious, I couldn’t re-enable Layout Plugin at this point.

Finally, I had a similar project to start, so I took a raw 8.3.6 site and added Panelizer which required Layout Discovery. So far so good, then I attempted to install AT Tools, AT Theme Generator and Layout Plugin. This resulted in

“Fatal error: Cannot use object of type Drupal\Core\Layout\LayoutDefinition as array in mysiteroot\modules\layout_plugin\src\Plugin\Layout\LayoutPluginManager.php on line 162”

I hope this information is useful in some way.

@Grabby

The issues you describe are known. Please read #33, which explains the steps you need to follow until these issues are fixed and the fixes reach a stable release.

@nedjo thanks. I’m developing a multilingual site and now the translation for AT Theme Generator won’t update, but I’ll take this as the greatest of my worries!

Great job nedjo
I followed the instructions #33
I tried it on a dev site and it works fine.
Thanks for the job.

It is no longer necessary to apply any patches if you are trying to install AT Tools and Adaptivetheme on Drupal 8.3. Just use the 8.2.x development releases of AT Tools and Adaptivetheme until there is a 8.x-2.1 release of AT Tools and a 8.x-2.1 release of Adaptivetheme.

But is there a release that will work for updating? All the successes so far seem to be referencing new installs. :/

Nope. Updating will get you in trouble... And since the maintainer has dropped off the face of the earth.. you might get lucky with the (another) patch approach until that one also fails in the future or wait until someone steps up and takes over the project..

In my particular case this problem is not the end of the world since I use AT on a local project (not yet live) but I can imagine the troubles if you use AT on live sites... Though I pm'd Jeff some time ago I never received an answer... So I guess it's the end of AT.
.

At #40, @nedjo tried it on a clean install and it seems to works with D8.3.7 together with DS 8.x-3.1. Sofar so good.
However: Now I have a production site still on D8.2.6 with AT1.0 et cetera. I suppose the only way now to get to the new AT2.0 and D8.3.7 is to deinstall it, remove it, inclusive module: Layoutplugin and the DS module and start over again? What damage will that do? Seems like a whole lot of work. Any suggestions or experiences to share before I enter into this twilight zone?

Thank you, Jeff. I appreciate all your work - I wish I were smart enough to help. I can certainly test upgrade attempts for you... I have a handful of sites using AT/D8 and at least 7 on AT/D7, and the D8 ones are stuck in 8.2.# until things settle - never even made it into 3. Can I do anything?

Sweet jeebus! I shall give it a try the next time I have spare time. And, while I have a spare dime, how do I buy you a beer or something?

I second justkristin's response. I'm extremely grateful for all the work put into this theme. I would be happy to help fund maintenance and development. It would be great to have a way to do that.

I just did a fresh install of Drupal 8.4.2 and ran into this problem. Am i sol or is there some kind of work around?

I would like to say that I have manually upgraded to the latest dev versions, uninstalled Layout Plugin, installed Layout Discovery and everything seems to be working great.

Drupal core 8.4.2 - AdaptiveTheme 8.x-1.0 - (Not supported!) AT Tools 8.x-1.1 - Display Suite 8.x-3.1

Looking at upgrading an active production site I have built, which I'm very happy with,using the 8.x-1.x branch as I see now at_tools 8.x-1.1 is no longer supported. I have some questions and would really appreciate any help at all.

1. Will the 8.x 1 branch still continue to work away or is it a risk to keep using it this way, The site is growing daily and has a few hundred members?

2. Is it possible to export the configuration settings from a theme generated on 1.x and import to one on the 3.x or will I have to set all of the those setting manually again? I use a lot of views and blocks with user role permissions, and Access by Taxonomy, as I have different roles paying for different content. Its quire complex but works well and fast with Display Suite !

3. I have brought the site into a local environment, mamp 4 pro, and experimented a bit in the last day or two, upgraded to 3.x Theme and Tools, and generated a theme and Display suite works but I have lost all my block configurations, even after importing, config sync, custom css and site-builder.markup.yml to its page-layout.markup.yml version. The regions are all there ok after saving the layout and the content nodes display well, I use paragraphs and custom blocks too.

4. I tried generating a theme of the same machine name in 3.x and then importing config, but that doesn't work either. WSOD..

5. From my own position, (I'm not a professional developer and my coding consists of copy and paste in the most part, but I have always liked doing this Drupal thing for myself, 7 years now.) it looks as if I will just have to go through all the config settings for my extensions and blocks.. that may take a few days of very tedious work..

6. Will 3.x continue to be maintained and upgrade paths made to work easily in the future, as i really like this theme, thanks Jeff..

7. How best can I support your work Jeff?

8. I see you, gdelver@xs4all.nl have a similar issue.

Hi Jeff, thanks, I sent an email with a link to dropbox as your gmail refused attached zips.

That's good that it will keep working as I don't feel the need to generate a new upgraded theme as yet. I did try 8.x-3.x AT tools on local with 8.x-1.x theme and its seemed to work ok.

Display Suite 8.x-3.1 and Layout Discovery, not using Layout Plugin module now. Looking forward to your comments. Alex

I would like to upgrade my site hejaolika.se that today uses:
Drupal 8.2.8
AdaptiveTheme 8.x-1.0
AT Tools 8.x-1.1
Display Suite 8.x-2.6.

I have tried to upgrade it in some different ways (manually deleting old folders and adding new) without success.
Do you have any recommendations on how to do this?

Hi Jeff.

Are we any further in mapping an upgrade path from Adaptive 8.x-1.x branch to 8.x-3.1.

I'm using Drupal core 8.4.5 - AdaptiveTheme 8.x-1.0 AT Tools 8.x-1.1 - Display Suite 8.x-3.1 - Layout Discovery 8.4.5

I ran into some errors using webform 8.x-5.0-rc3 r and I haven't taken the time to trace them or sort it out yet because I would like to upgrade to Adaptive to 8.x-3.1. branch and work from there.

Thanks.