Fix some deprecated methods [#2855959]

Few small fixes: deprecated methods, removing any unused classes, variables etc. Hope this of use)

I did originally try adding the label next to each field instance (after the link) on admin/reports/fields/tools, but wasn't sure if people would find it more clutter than useful - i.e. whether different labels are used for each instance all that often.

Comment	File	Size	Author
#2	2855959.patch	7.41 KB	wturrell
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

25 February 2017 at 15:06

wturrell created an issue. See original summary.

Comment #2

wturrell CreditAttribution: wturrell as a volunteer commented 25 February 2017 at 15:07

File	Size
2855959.patch	7.41 KB

Comment #3

27 February 2017 at 14:10

joachim committed 7bcadbb on 8.x-1.x authored by wturrell

Issue #2855959 by wturrell: Fixed some deprecated methods and removed...

Comment #4

joachim CreditAttribution: joachim as a volunteer commented 27 February 2017 at 14:11

Status:

Active

» Fixed

Cool, thanks for the patch!

I've committed most of it, apart from the folllowing:

```
diff --git a/field_tools.admin.inc b/field_tools.admin.inc
```
This file is obsolete. It's not being used in D8, so there's no point updating it. I've kept it in for now so I can keep track of the functionality that still needs to be implemented... though that might not be the best way. I should probably remove it and file an issue instead, to avoid confusion! :)

+++ b/src/Plugin/Derivative/FieldToolsLocalTask.php
@@ -26,7 +26,7 @@ class FieldToolsLocalTask extends DeriverBase implements ContainerDeriverInterfa
-   * @var \Drupal\Core\Entity\EntityManagerInterface
+   * @var \Drupal\Core\Entity\EntityTypeManagerInterface
    */
   protected $entityManager;

Changing the service to use the non-deprecated one is definitely a good idea, but then the variable and parameter names should be changed to match. This could be tackled in another issue, though don't feel obliged :)

Comment #5

wturrell CreditAttribution: wturrell as a volunteer commented 27 February 2017 at 15:38

Thanks - did wonder if field_tools.admin.inc was obsolete but decided to leave in case there was some reason for it being there.
Only started learning how to write modules very recently, but may return to some of the other todo items when I know more..