[D8] VotingAPI Queue

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

Passed by pareview.sh (https://pareview.sh/node/1247). Well done !

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

The README.md is very impressive, nice work.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

1. (+) You parameters when translate dynamic string. Otherwise it will generate a custom translation for each dynamic variables.
   Spotted line 115 of votingapi_queue.drush.inc
dt("Adding $limit items for processing.");
2. Just a recommendation, all but the most trivial modules should implement hook_help(). Check the guidelines for in-project documentation.
3. Just a recommendation, if you don't want to add help, you then should removed empty file votingapi_queue_cron_worker.module.
4. Just a recommendation, it seems you forget use dt() lines 75, 169 & 170 of votingapi_queue/votingapi_queue.drush.inc.
5. Just a recommendation, you could split your votingapi_queue.module by .inc files for better readability. Specially the settings part.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Nice work dude ! Your code is quite elegant, good job !

This review uses the Project Application Review Template.

Your plugin should use dependency injection instead of calling global Drupal and Cache classes. See https://www.drupal.org/docs/8/api/services-and-dependency-injection/depe...

Otherwise looks good to me, and since you have lots of other contributions already ....

Thanks for your contribution, Andre!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Assigning credits.