CommentFileSizeAuthor
#5 metatag-replace_all_of_deprecated_usages-2855445-5.patch4.92 KBbkhandruk
#2 metatag-replace_usages_of_deprecated_entity_load_multiple_by_properties-2855445-2.patch1.88 KBbkhandruk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rocket.man created an issue. See original summary.

bkhandruk’s picture

bkhandruk CreditAttribution: bkhandruk commented
Assigned: bkhandruk » Unassigned
Status: Active » Needs review
FileSize
metatag-replace_usages_of_deprecated_entity_load_multiple_by_properties-2855445-2.patch1.88 KB

Replaced usages of entity_load_multiple_by_properties.

Status: Needs review » Needs work

The last submitted patch, 2: metatag-replace_usages_of_deprecated_entity_load_multiple_by_properties-2855445-2.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Replace usages of deprecated entity_load_multiple_by_properties » Replace deprecated functions

Lets generalize this to cover all of the deprecated functions, rather than going through the module function-by-function.

bkhandruk’s picture

bkhandruk CreditAttribution: bkhandruk commented
Status: Needs work » Needs review
FileSize
metatag-replace_all_of_deprecated_usages-2855445-5.patch4.92 KB

This one covers all of deprecated usages.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed
Parent issue: » #2563615: Plan for Metatag 8.x-1.1 release

Thanks! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Related issues: +#3088848: Drupal 9 release plan for Metatag (ETA: when D9.0.0-beta1 is released)