Support from Acquia helps fund testing for Drupal Acquia logo

Comments

juho-jaakkola created an issue. See original summary.

juho-jaakkola’s picture

I haven't made a patch in a long time. Hopefully I'm doing it right.

juho-jaakkola’s picture

FileSize
827 bytes

Well, that was an utter failure. Here's another try.

juho-jaakkola’s picture

Assigned: juho-jaakkola » Unassigned
Status: Active » Needs review
kristiaanvandeneynde’s picture

Thanks for the patch! I'd like to hold off on committing third-party integrations until we have a stable release. In the mean time, we can use this issue to garner feedback on the patch.

juho-jaakkola’s picture

Patch updated to give entity_type.bundle.info service as third parameter to FeedForm.

MegaChriz’s picture

Status: Needs review » Closed (works as designed)

Looking at the code, I think this one can be closed. In Feeds 8.x-3.0-alpha2 there is now a processor available for every content entity type (made possible with using a deriver). A speficic processor only needs to be created if the entity type requires special handling. This seems to be the case for the Group content entity type, where some fields are set to read-only. See #2991289: Feeds integration: Group content processor.