Problem/Motivation

Currently the advagg installer advagg_install() throws exceptions when re-installing a site / the module.
The function creates the folders public://css and public://js without checking first if the folders already exists. This can cause exceptions which can interrupt the installation.

Proposed resolution

Check if the folders exists before trying to create them.

Remaining tasks

Reviews needed.

CommentFileSizeAuthor
advagg-make-installer-more-defensive.patch971 bytesdas-peter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

das-peter created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, advagg-make-installer-more-defensive.patch, failed testing.

das-peter’s picture

das-peter CreditAttribution: das-peter at Cando commented

Running re-test - that fail looks random.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Status: Needs work » Fixed

All the tests on 8.4.x are failing, I'll look into that later, but for now tests fine on 8.2 (and looks fine for everything).
Applied, thanks.

  • NickWilde committed 252e2f7 on 8.x-2.x authored by das-peter 
    Issue #2854673 by das-peter: Avoid exception on site / module re-install

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.