We're running automated testing and the addition of the following lines (added in 3.2) in views_slideshow_cycle.install (14-17) are causing our testing build to fail.

// If installing via Drush skip requirement checking here.
  if (php_sapi_name() == 'cli') {
    return;
  }

I propose we remove this Drush install skip requirements statement from the install file.

CommentFileSizeAuthor
#2 drush-cli-check-remove-2854640-2.patch644 bytesowenpm3
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

owenpm3 created an issue. See original summary.

owenpm3’s picture

owenpm3 CreditAttribution: owenpm3 at University of Colorado Boulder commented
Component: Code » Cycle
FileSize
drush-cli-check-remove-2854640-2.patch644 bytes
owenpm3’s picture

owenpm3 CreditAttribution: owenpm3 at University of Colorado Boulder commented
Status: Active » Needs review
NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented

What error is that getting/how is it causing it to fail?

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented

(to be clear, that or something similar is required or install fails via drush)

owenpm3’s picture

owenpm3 CreditAttribution: owenpm3 at University of Colorado Boulder commented

The install profile needs to have a dependency stated for views_slideshow_cycle. I just added these two lines to the standard install profile and ran it via drush si.

dependencies[] = views_slideshow
dependencies[] = views_slideshow_cycle

Here's the output:

$ drush si standard --db-url=mysql://root:root@localhost/omd7yes --account-name=admin --account-pass=admin
You are about to DROP all tables in your 'omd7yes' database. Do you want to continue? (y/n): y
Starting Drupal installation. This takes a while. Consider using the --notify global option.                                                                [ok]
WD php: Warning: array_merge(): Argument #2 is not an array in drupal_check_profile() (line 1189 of /Users/user/sites/d7/includes/install.inc).         [warning]

Fatal error: Unsupported operand types in /Users/user/sites/d7/includes/install.core.inc on line 746
Drush command terminated abnormally due to an unrecoverable error.                                                                                          [error]
Error: Unsupported operand types in /Users/user/sites/d7/includes/install.core.inc, line 746

So it's not automated testing, it's installing with a profile listing views_slideshow_cycle as a dependency. I traced that down to the following lines noted above.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented

ah okay, that makes sense.
The problem is that the install command expects an array whereas that is returning null.
easy fix, coming right up.
Thanks for reporting and the details!

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Title: views_slideshow_cycle.install Drush cli check breaks testing » views_slideshow_cycle.install cli check breaks profile installation
Status: Needs review » Fixed

  • NickWilde committed b03c6d3 on 7.x-3.x 
    Issue #2854640 by owenpm3, NickWilde: views_slideshow_cycle.install cli...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.