The problem is type conversion in PHP (as usual) in the following method of Nodejs service:

  public function safeNodeServerVersion() {
    if ($this->nodeServerVersion === NULL) {
      $this->healthCheck();
    }
    return $this->nodeServerVersion && $this->nodeServerVersion >= self::SAFE_NODE_SERVER_VERSION;
  }

As you see it just compares two strings and while the patch version was one-digit everything was fine. But with 1.0.10 it returns FALSE while it should return TRUE.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Angerslave created an issue. See original summary.

Angerslave’s picture

Assigned: Angerslave » Unassigned
Priority: Normal » Major
Status: Active » Needs review
FileSize
774 bytes

In general 7.x branch approach looks fine (using version_compare() is better than blind string comparison), so I just took it and made it a little more compact.

  • beejeebus committed f7a7ae6 on 8.x-1.x authored by Angerslave
    Issue #2854574 by Angerslave: npm package version 1.0.10 breaks...
Anonymous’s picture

Status: Needs review » Fixed

thanks, pushed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.