Changed translation function on $ this->t()

CommentFileSizeAuthor
#3 changed_translation-2854353-3.patch4.13 KBpurushotam.rai
auto_entitylabel_t.patch3.27 KBpifagor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pifagor created an issue. See original summary.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Assigned: Unassigned » Pavan B S
Status: Needs review » Reviewed & tested by the community

Patch is working fine

purushotam.rai’s picture

purushotam.rai CreditAttribution: purushotam.rai at QED42 commented
FileSize
changed_translation-2854353-3.patch4.13 KB

Further Improvements

  • purushotam.rai committed b9a73d2 on 8.x-1.x 
    Issue #2854353 by pifagor, purushotam.rai: Changed translation function...
purushotam.rai’s picture

purushotam.rai CreditAttribution: purushotam.rai at QED42 commented
Status: Reviewed & tested by the community » Fixed

Thanks for all your input.

Peacog’s picture

Peacog CreditAttribution: Peacog as a volunteer commented

This commit introduced a bug at this line:
'#description' => $this->$this->t('Put PHP code above that returns your string, but make sure you surround code in <code>&lt;?php and ?&gt;. Note that $entity and $language are available and can be used by your code.'),

The latest patch at #2755445: Auto Entity label does not set entity labels and breaks contrib modules fixes it

  • purushotam.rai committed b9a73d2 on 8.x-2.x 
    Issue #2854353 by pifagor, purushotam.rai: Changed translation function...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community commented