Hi guys, how are you?

Please, the follow variables should be removed when uninstall:

In attachment the patch with the fix.

Good work and good week.

Regards.

CommentFileSizeAuthor
#4 interdiff-2854152-3-4.txt620 bytesMegaChriz
#4 feeds-remove-variables-uninstall-2854152-4.patch1.64 KBMegaChriz
#3 interdiff-2854152-0-3.txt1.84 KBMegaChriz
#3 feeds-remove-variables-uninstall-2854152-3.patch1.59 KBMegaChriz
feeds_variables-removeds-uninstall_0.patch744 bytesrenatog
1.png36.07 KBrenatog
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Status: Active » Needs review
MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
FileSize
feeds-remove-variables-uninstall-2854152-3.patch1.59 KB
interdiff-2854152-0-3.txt1.84 KB

Good catch! Though some variables are only used by the feeds_tests module, so these should be uninstalled by feeds_tests, not feeds. I also found some more variables that should be removed on uninstall.

New patch.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
FileSize
feeds-remove-variables-uninstall-2854152-4.patch1.64 KB
interdiff-2854152-3-4.txt620 bytes

Added removal of variable 'feeds_tests_feeds_after_save_sleep' in feeds_tests_uninstall().

  • MegaChriz committed c63c4b9 on 7.x-2.x authored by renatog 
    Issue #2854152 by renatog, MegaChriz: Delete feeds variables when upon...
MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Status: Needs review » Fixed

Committed #4. Thanks!

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented

Perfect @megachriz. Good catch.

Thank you very much!

Hugs.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.