[D7] Facebook page feed

fix this errors

FILE: /root/repos/pareviewsh/pareview_temp/fbpagefeed.module
--------------------------------------------------------------------------
FOUND 3 ERRORS AND 6 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------
9 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
10 | ERROR | [ ] Doc comment short description must be on a single
| | line, further text should be a separate paragraph
42 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
50 | ERROR | [x] Whitespace found at end of line
52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
57 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
62 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: DRUPAL_NO_CACHE
68 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
87 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/facebook-box.tpl.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
7 | ERROR | [x] Doc comment short description must end with a full stop
7 | ERROR | [ ] Doc comment short description must be on a single line,
| | further text should be a separate paragraph
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/fbpagefeed.info
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

using tool https://pareview.sh/

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi @puspanjalim,

Very well, i see your module's file,

a). I think its a good idea to implement hook_help();
b). In fbpagefeed.info include "configure = admin/config/content/fbpagefeed'.
c). integrate hook_permission();

see you.

Good to see you implemented hook_help. I think it's a good idea to make the content translatable. Just take a look at the documentation for an example.

You also implemented hook_permission and added the permission 'administer fbpagefeed', but in hook_menu, you used the access argument 'administer users'. See:

  $items['admin/config/content/fbpagefeed'] = array(
    'title' => 'Facebook feed configuration',
    ...
    'access arguments' => array('administer users'),
    'type' => MENU_NORMAL_ITEM,
  );
  return $items;

Please add the t-function to your placeholder attribute in 'fbpagefeed_form' (line 62).

/**
 * Creates Facebook page url entry form.
 */
function fbpagefeed_form($form, &$form_state) {
  $current_domain = fbpagefeed_get_current_active_domain();
  $facebook_page_url = $current_domain . "facebook_page_url";
  $form["fbpagefeed_url"] = array(
    '#type' => 'textfield',
    '#default_value' => variable_get($facebook_page_url),
    '#title' => t('Enter facebook page url'),
    '#rows' => 3,
    '#required' => TRUE,
    '#attributes' => array('placeholder' => 'Please Enter Facebook Page Url'),
  );
  return system_settings_form($form);
}

@puspanjalim,
use js file for facebook script, do not write script tag on tpl file.

@agautam: that alone is surely not an application blocker, anything else that you found or should this be RTBC instead?

@Puspanjalim,

Below are my reviews:

1) Please use t() in hook_help.
2) variable which is set by module , must be deleted after module unistall , use hook_uninstall in module.install file.
3) You have used

helping to set the right status to this issue as it waits for the maintainer response.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.