Address remaining @todo in EntityResourceTestBase [#2853296]

Comment	File	Size	Author
#2	2853296-2.patch	1.59 KB	Wim Leers
8.3.x: PHP 5.6 & MySQL 5.5 21,632 pass

Comment #1

16 February 2017 at 19:00

Wim Leers created an issue. See original summary.

Log in or register to post comments

File	Size
2853296-2.patch	1.59 KB
8.3.x: PHP 5.6 & MySQL 5.5 21,632 pass

Comment #3

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Acquia commented 16 February 2017 at 19:59

Status:

Needs review

» Reviewed & tested by the community

Ok looks good

Log in or register to post comments

Comment #4

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 16 February 2017 at 21:35

Status:

Reviewed & tested by the community

» Fixed

Committed/pushed to 8.4.x and cherry-picked to 8.3.x. Thanks!

Log in or register to post comments

Comment #7

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 16 February 2017 at 21:38

Title:

Follow-up for #2820743: address remaining @todo

» Address remaining @todo in EntityResourceTestBase

Issue #s in other issues' titles does weird things to our d.o VCS integration, so retitling.

Log in or register to post comments

Comment #8

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 16 February 2017 at 21:38

Oh bummer, I was too late. ;)

Log in or register to post comments

Comment #9

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 17 February 2017 at 10:30

Thanks!

Issue #s in other issues' titles does weird things to our d.o VCS integration, so retitling.

Hah, I didn't know. Hm, I don't see any comments being posted to #2820743: FieldNormalizers are very unforgiving, impossible to debug error response given, so is that still a problem? Besides, seeing the commit message for this issue appear there too would not have been a bad thing at all.