The ThemeInstaller class is missing the protected variable definition for themeHandler. Similar definitions exist for all other constructor/injected variables. This affects the API, improperly exposing a variable that was never meant to be exposed.

CommentFileSizeAuthor
#3 ThemeInstaller-themeHandler.patch842 bytesalexpott
ThemeInstaller-themeHandler.patch842 bytesdouggreen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

douggreen created an issue. See original summary.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Needs review » Reviewed & tested by the community

Thank you for catching that @douggreen and the patch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Chapter Three commented
FileSize
ThemeInstaller-themeHandler.patch842 bytes

For some reason the tests have not run.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Chapter Three commented
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 607efe2 and pushed to 8.4.x. Thanks!

+++ b/core/lib/Drupal/Core/Extension/ThemeInstaller.php
@@ -7,6 +7,7 @@
+use Drupal\Core\Extension\ThemeHandlerInterface;

This is not used - fixed on commit.

  • alexpott committed 607efe2 on 8.4.x 
    Issue #2853163 by douggreen: ThemeInstaller is missing protected...

  • alexpott committed 5acfdbf on 8.3.x 
    Issue #2853163 by douggreen: ThemeInstaller is missing protected...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.