A patch to improve speed, ad functionality, and fix bugs.

Solves the following issues..could not post in separate patches because the code in question was all lumped together.

Image style derivative is always generated, even if available
https://www.drupal.org/node/2611470

Support for relative path
https://www.drupal.org/node/2853035

Token for mimetype will never get created for images
https://www.drupal.org/node/2853027

token for image derivate path appends "%3Apath" to image style name part of url
https://www.drupal.org/node/2744265

Image style derivative not create when using first, second, third tokens
https://www.drupal.org/node/2853083

Also adds support for 'last' and numerical selection for multivalued fields.

CommentFileSizeAuthor
#11 improve-speed-add-functionality-fix-bugs-11.patch8.33 KBmonstrfolk
#8 provide_a_public-2511742-7.patch9.06 KBmonstrfolk
#7 provide_a_public-2511742-7.patch9.06 KBmonstrfolk
#4 improve-speed-add-functionality-fix-bugs-4.patch8.26 KBmonstrfolk
#3 improve-speed-add-functionality-fix-bugs-3.patch7.67 KBmonstrfolk
improve-speed-add-functionality-fix-bugs.patch5.56 KBmonstrfolk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

monstrfolk created an issue. See original summary.

monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
Status: Active » Needs review
monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
Issue summary: View changes
FileSize
improve-speed-add-functionality-fix-bugs-3.patch7.67 KB
monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
FileSize
improve-speed-add-functionality-fix-bugs-4.patch8.26 KB

Added image style derivatives to be properly created when using first, second, third, last, and integer tokens.

monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
Issue summary: View changes
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work

A minor thing - the description of each param needs to follow the standard commenting rules, i.e. structured as a sentence, have a period at the end, acronyms should be in uppercase, etc. Otherwise it looks good.

monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
FileSize
provide_a_public-2511742-7.patch9.06 KB

Thank you for your review. New description block below.

/**
 * Helper function to generate image style if does not exist.
 *
 * @param string $styled_uri
 *   URI for image style.
 * @param string $type
 *   Machine name for image style.
 * @param string $field_uri
 *   URI of field to be styled.
 */

Also added one small fix to check if index selected for multi-value fields exist.

monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
FileSize
provide_a_public-2511742-7.patch9.06 KB

Uploaded patch again for testing. Last patch was uploaded with testing off by accident.

monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: provide_a_public-2511742-7.patch, failed testing.

monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
FileSize
improve-speed-add-functionality-fix-bugs-11.patch8.33 KB

Wrong patch.

monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
Status: Needs work » Needs review

  • monstrfolk committed 67230de on 7.x-1.x 
    Issue #2853037 by monstrfolk, DamienMcKenna: Rewrite logic of tokens to...
monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

anni’s picture

anni CreditAttribution: anni commented

I applied the patch but the problem is still the same. The code now is: $output[] = image_style_url($type, $field['uri']); at line 265 but still I get %3Apath inserted.

anni’s picture

anni CreditAttribution: anni commented

Suddenly it works.