When I hit "Update Status" on a task and I'm using hosting_queued, it gets stuck.

Even deleting the row in semaphore won't get it started again.

I have to restart the queue process to get it running again,

We should figure out a way to notify hosting-queued process to reload the task list?

Comments

Jon Pugh created an issue. See original summary.

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Title: Cancelling a task stalls the queue because the semaphor is still present. » Cancelling a task stalls the queue even if the semaphor is still present.
helmo’s picture

helmo commented

This happens when the task is already running? or even when it's just queued?

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented

Now you can see the tasks starting and stopping in the logs. If you Cancel a task before it completes, you never see the "Finished task" message.

The code reporting those messages is in hosting_task_execute()

helmo’s picture

helmo commented

How are you even canceling a task that's already running? In hosting_task_cancel() it specifically filters on HOSTING_TASK_QUEUED.

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Title: Cancelling a task stalls the queue even if the semaphor is still present. » "Update Status" button does not remove hosting queued semaphore, stalling the queue

Sorry, I mean the "Update Status" button, which works on running tasks.

I think the problem is that the hosting.module form isn't aware of hosting_queued, so it doesn't remove the lock?

Not sure. Perhaps the fix should be in hosting_queued()

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Issue summary: View changes
jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Status: Active » Needs review

Pushed changes to branch 2852966-queued-locks that removes the lock on submit of the button, but the process still continues.

I'm not sure we can do anything to stop it short of finding the PID and running "kill"!

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented

Just FYI I discovered a bit about signals:

Found the PID of "php" process running under aegir user using top:

aegir@aegir:~$ kill -SIGHUP 306

Successfully triggered a restarting of the queue daemon.

helmo’s picture

helmo commented
Status: Needs review » Reviewed & tested by the community

Does this feature branch still hold a benefit? I guess so ... the 'update status' button is added with the comment "Adds button to update the status of task nodes stuck in the 'processing' state." so it seems logical to remove the lock.

  • helmo committed 204c134 on 7.x-3.x 
    Issue #2852966: Merge remote-tracking branch 'origin/2852966-queued-...
helmo’s picture

helmo commented
Status: Reviewed & tested by the community » Fixed

Merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.