There are some helper/utility functions in this module with generic names like flatten_array_by_cids and _replace_value_in_recursive and _array_flatten that should be renamed to include the name of the module.

Though it's true that these are not hooks and do not *need* the name of the module to work properly, there is a high risk that another module might also define a function named _array_flatten, which could cause us both problems. If we were to name this function _authorizenetwebform_array_flatten instead, all problems could be avoided.

Comments

jenlampton created an issue. See original summary.

  • jenlampton committed 243fa5e on 7.x-1.x
    Issue #2852706: Helper functions start with the module name to avoid...
jenlampton’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.