Problem/Motivation

The comparison in cshs_form_select_options does not handle integer and string values very well. Because "a string" == 0 is always true.

Proposed resolution

Cast both values to a string. form_select_options does similar things, maybe we should backport some of the changes from form_select_options to cshs_form_select_options.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2852474-1.patch685 byteswebflo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo created an issue. See original summary.

webflo’s picture

Status: Active » Needs review
FileSize
685 bytes
stefan.r’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +blocker
Related issues: +#2853860: Override parent menu item selector to deal better with large menus

As form_select_options does the same this fix seems OK

  • valderama committed 45555ba on 8.x-1.x authored by webflo
    Issue #2852474 by webflo: cshs_form_select_options does not work with...
stefan.r’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.