Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Some websites show elements with seamless horizontal seamless scrolling.
Unknown if slick can do this too.
It supports infinite, but unknown if it supports permanent scrolling without fixed position.
Proposed resolution
Research.
Add option or new plugin.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#21 | infinite_slider_for_demo-2852165-21.patch | 7.87 KB | btemperli |
#19 | infinite_slider_for_demo-2852165-19.patch | 2.62 KB | btemperli |
#13 | infinite_slider_for_demo-2852165-13.patch | 8.71 KB | btemperli |
| |||
#9 | infinite_slider_for_demo-2852165-9.patch | 8.56 KB | btemperli |
| |||
#6 | infinite_slider_for_demo-2852165-6.patch | 8.47 KB | btemperli |
Comments
Comment #2
miro_dietikerExamples: Used for customer logos or testimonials scrolling.
Comment #3
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedThis is actually already doable with the slider plugin and appropriate slick configuration. What we could do is to provide the slick config file and/if needed a paragraph type if needed.
Comment #4
miro_dietikerWould be great as a second slick paragraph in the demo.
Comment #5
btemperli CreditAttribution: btemperli commentedComment #6
btemperli CreditAttribution: btemperli commentedI added a new/second slider to the demo which is automatically scrolling horizontal.
Comment #8
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedThis looks really nice. Just two things for now:
You will need to clone paragraphs_collection and then create the patch from there. That's why it failed to apply.
I think that there is no need for that, because paragraphs_collection already requires slick_ui.
Comment #9
btemperli CreditAttribution: btemperli commentedThank you Primsi for looking at it!
I checked the patch again. Should work now, the problem was that in the meantime another commit was published in the module. Failed of that I think.
Comment #10
btemperli CreditAttribution: btemperli commentedComment #11
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedOh snap, completely off on this one. Did it in a hurry and didn't spent enough time to check it properly.
That's really strange that we need a dependency on slick_ui. I guess there is nothing we can do about it.
Not sure about using text for this. I think that the intention is to have something like 3 images that scroll endlessly. That will actually look different from the already exiting slider.
Comment #12
miro_dietikerSo if we create option sets, we need slick_ui dependency? Sounds strange and we should create an issue over there to not require this.
Comment #13
btemperli CreditAttribution: btemperli commentedComment #14
johnchqueWow really nice! We would need tests for this but not sure how much needed they are. RTBC +1.
Comment #15
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedJust one nitpick. Otherwise great work! Also IMHO this would count more as a fundamental type, so I don't think we need tests for this demo item, as discussed in another issue.
We use the new array syntax everywhere in this file, let's not mix them up.
Comment #17
miro_dietikerReally cool. Committed it with the array fix to allow us easily play with it. Back to work to talk about next steps...
- All images look the same. Would be great to have them slightly differ. Could be different horizontal width.
- Why do we need a new "slider indefinite" paragraph type instead of selecting that style in the option set?
Comment #18
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedIn the demo slider contains a text field.
Comment #19
btemperli CreditAttribution: btemperli at Gridonic commentedI'm back at working on this ticket. Sorry for the long delay :)
I updated the infinite image slider:
- Images are not same size anymore, added some with different width
- Scrolling is now seamless, no stops at each image.
Comment #21
btemperli CreditAttribution: btemperli at Gridonic commentedUpdated the patch.
I also removed the paragraph type "slider infinite" as said in #2852165-17: META Infinite horizontal scrolling and replaced it by the paragraph type "slider", just with the other optionset.
Comment #23
miro_dietikerSeems we forgot to review this. Promoting for better visibility.