Summary
This module is an extension to Drupal Commerce payment system which integrates Armenian ArCa IPay off-site payment method to Commerce.
After enabling Payment method rule and putting credentials attained from ArCa it appears in payment methods listing checkout pane.
Project Page
Commerce ArCa
Git instructions
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/tiko/2851134.git commerce_arca
cd commerce_arca
Reviews of other projects
https://www.drupal.org/node/2124793#comment-8132813
https://www.drupal.org/node/2840398#comment-11934414
https://www.drupal.org/node/2854053#comment-11955408
Comments
Comment #2
tiko CreditAttribution: tiko commentedComment #3
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxtiko2851134git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4
tiko CreditAttribution: tiko commentedFixed reported errors/warnings.
Comment #5
tiko CreditAttribution: tiko commentedComment #6
jeetendrakumar CreditAttribution: jeetendrakumar as a volunteer and at HyTechPro.com commented@tiko,
Please fix errors reported by automated review tools:
https://pareview.sh/node/1076
Comment #7
tiko CreditAttribution: tiko commentedThanks for your response.
As mentioned in Drupal Commerce documentation the Paypal module is taken as an example which I used and I would like to pay your attention that same issues exist for Paypal module.
I've corrected some issues which you can see in last commits list but meanwhile I think that some issues are not mandatory, for example:
Comment #8
tiko CreditAttribution: tiko commentedComment #9
klausiRemoving review bonus tag, you have not listed all reviews of other project applications? Make sure to read https://www.drupal.org/node/1975228 again and add it back once you did those reviews.
Comment #10
tiko CreditAttribution: tiko commentedComment #11
tiko CreditAttribution: tiko commentedComment #12
tiko CreditAttribution: tiko commentedI've added manual reviews.
Comment #13
Kostya19 CreditAttribution: Kostya19 commentedI made a manual review and partially tested the module.
The module meets Licensing requirements, Code long, I do not find secure issues.
There are some minor issues in the code style and documentation, some of them are inherited from the paypal module.
1. Unused variable
$settings
in line 186.2. Expected 1 newline at end of file
commerce_arca.info
3. Some of comment lines exceeds 80 characters
4. Some issues of documentation standards for functions (missing parameter type, return type missing, additional blank lines found at end of doc comment)
5. Using
$(document).ready()
instead ofDrupal.behaviors
(see https://www.drupal.org/node/304258). Perhaps you should consider changing the availability of an element without using JS, infunction commerce_arca_form_commerce_checkout_form_alter()
Comment #14
tiko CreditAttribution: tiko commentedThank you Stray14, I appreciate your effort for reviewing my module.
I've corrected first two lines and decided not to do them for other points.
For third and forth points I've written in previous comment. In commerce documentation is written to take as an example from paypal module so I did.
And ultimately the javascript code is very tiny and I think its not necessary to create separate js file. In the future if more javascript features will be needed I'll add file with behaviors.
Thanks.
Comment #15
MatroskeenHello @tiko,
I've made a manual review of your module and it looks good to me.
I've created two minor issues and attached patches:
#2938262: Coding standards erorrs
#2938266: Module name
Could you review, please? Thanks!
Comment #16
apadernoTo the reviewers: Please set the priority to Normal after reviewing this application.
Comment #17
sleitner CreditAttribution: sleitner commentedAutomated Review
pareview details: https://pareview.sh/pareview/https-git.drupal.org-sandbox-tiko-2851134.g...
Review of the 7.x-1.x branch (commit bb5f9da):
hook_help()
. See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .This automated report was generated with PAReview.sh, your friendly project application review script.
Manual Review
name = Commerce ArCa
dependencies[] = commerce_payment_ui
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #18
apadernoIf you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.
I am closing this application due to lack of activity.