Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This module (https://www.drupal.org/sandbox/jaza_sa/2700079) allows the SMS Framework (http://drupal.org/project/smsframework) to use WebKaran (http://sms.webkaran.ir) as a gateway to send SMS.
Git Repository:
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/jaza_sa/2700079.git sms_webkaran
Comments
Comment #2
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjaza_sa2700079git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
jaiiali CreditAttribution: jaiiali commentedI tried to fix all errors but still remains
Type hint "array" missing
error. (https://pareview.sh/node/1111)Is it possible to ignore these error?
Comment #4
jaiiali CreditAttribution: jaiiali commentedComment #5
puspanjalim CreditAttribution: puspanjalim as a volunteer commented@jaiiali
In module file at line number 77 you have initialize $options as array but you have not used this variable in the function scope.
So you can remove this variable.
If you want to use then type hint as array $options.
Comment #6
puspanjalim CreditAttribution: puspanjalim as a volunteer commentedComment #7
visabhishek CreditAttribution: visabhishek as a volunteer and at Azri Solutions commentedHi puspanjalim, Good suggestion , But surely this is not the application blocker, anything else that you found or should this be RTBC instead?
Comment #8
jeetendrakumar CreditAttribution: jeetendrakumar as a volunteer and at HyTechPro.com commented@jaiiali
Please add git clone command for non-maintainer users in Issue summary section.
Comment #9
jaiiali CreditAttribution: jaiiali commented@puspanjalim
Thank you, I do it and solved all problems. :)
@jeetendrakumar
I do it.
At this time, all problems of this module solved.
Please review it.
Comment #10
jaiiali CreditAttribution: jaiiali commentedComment #11
PA robot CreditAttribution: PA robot commentedProject 1: https://www.drupal.org/node/2857199
Project 2: https://www.drupal.org/node/2851856
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #12
jaiiali CreditAttribution: jaiiali commentedIf this module has no problem, please check it out faster.
Thank you.
Comment #13
apadernoTo the reviewers: Please change back the priority to Normal after doing a review.
Comment #14
apadernoThank you for your contribution!
Looking at the list of the committers, I see there are commits that aren't attributed to your account. Who did those commits?
Comment #15
apadernoI am closing this application for the lack of replies.