Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The validation upon importing users can be improved:
- When importing invalid user names (for example: with a bad character in it), the users are imported nevertheless.
- When importing an user with a name that is already in use, the user will get a SQL error:
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'Morticia' for key 'name'
- When importing an user with a mail address that is already taken, the user will be imported and you end up with two users with the same mail address!
Patch will follow.
Comment | File | Size | Author |
---|---|---|---|
#5 | interdiff-2851707-2-5.txt | 2.42 KB | MegaChriz |
#5 | feeds-user-validation-2851707-5.patch | 5.65 KB | MegaChriz |
| |||
#2 | feeds-user-validation-2851707-2.patch | 4.66 KB | MegaChriz |
#2 | feeds-user-validation-2851707-2-tests-only.patch | 3.03 KB | MegaChriz |
Comments
Comment #2
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedTests only patch should fail. Other patch should pass.
Comment #5
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedWhen an user ID is explicitly set, the validation checks for existing user names or existing mail addresses should be skipped. This is because the validation is based on the user ID and as such they do not make sense when one wants to update (or insert) the user ID.
Comment #7
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedCommitted #5.