The validation upon importing users can be improved:

  • When importing invalid user names (for example: with a bad character in it), the users are imported nevertheless.
  • When importing an user with a name that is already in use, the user will get a SQL error:
    SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'Morticia' for key 'name'
  • When importing an user with a mail address that is already taken, the user will be imported and you end up with two users with the same mail address!

Patch will follow.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MegaChriz created an issue. See original summary.

MegaChriz’s picture

Tests only patch should fail. Other patch should pass.

The last submitted patch, 2: feeds-user-validation-2851707-2-tests-only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 2: feeds-user-validation-2851707-2.patch, failed testing.

MegaChriz’s picture

Status: Needs work » Needs review
FileSize
5.65 KB
2.42 KB

When an user ID is explicitly set, the validation checks for existing user names or existing mail addresses should be skipped. This is because the validation is based on the user ID and as such they do not make sense when one wants to update (or insert) the user ID.

  • MegaChriz committed e7c2638 on 7.x-2.x
    Issue #2851707 by MegaChriz: Added user validation.
    
MegaChriz’s picture

Status: Needs review » Fixed

Committed #5.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.