Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The following error appear while updating the core to Drupal 8.3.0-dev
Fatal error: Class Drupal\plugin\PluginDefinition\ArrayPluginDefinitionDecorator contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Drupal\Component\Plugin\Definition\PluginDefinitionInterface::id) in /..../modules/contrib/plugin/src/PluginDefinition/ArrayPluginDefinitionDecorator.php on line 367
Comment | File | Size | Author |
---|---|---|---|
#8 | plugin-id-2851503-8.patch | 1.89 KB | Berdir |
#4 | plugin-id-2851503-4.patch | 2.37 KB | Berdir |
#2 | plugin-id-2851503-2.patch | 1.25 KB | Berdir |
Comments
Comment #2
BerdirNot sure why the core issue went with id() instead of getId() but this should fix it, lets see if something else is broken too.
Comment #4
BerdirCore doesn't find classes directly in tests/src anymore, moved to Unit, it's only used there. Actually it is more common that those are directly in the test class file that needs it, but maybe more will need it at some point.
Comment #5
tim.plunkettBetween #2350807: add getId() and make id() a wrapper for it and deprecate it and #2246695: replace all core usages of id() with getid(), pretty sure Xano (or was it tstoeckler?) would want it the opposite direction.
But yes, this works too. RTBCing for now.
Comment #6
andypostmissing in and when will be removed
Comment #7
BerdirWell yes, this is contrib, so I have no idea when it will be removed. 9.x-1.0? 8.x-3.0? Maybe before that we'll have semantic versions in contrib? Or maybe the referenced core issue will get in, which will turn this whole thing upside down anyway.
Honestly don't think we need to be so strict in contrib, maybe we should simply not deprecate anything yet, as we don't really know if id() or getId() will remain in the end.
Comment #8
BerdirHere's a version without the @deprecated.
Comment #9
tim.plunkett+1, I think this is entirely reasonable to commit as-is, and leave the debate to another issue.
Comment #11
BerdirThanks, committed!