Improve provided tours [#2851239]

Comment	File	Size	Author
#2	thunder_tour.gif	8.52 MB	slashrsm
#2	2851239_2.patch	13.97 KB	slashrsm

Comment #1

9 February 2017 at 17:49

slashrsm created an issue. See original summary.

Log in or register to post comments

Comment #2

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented 9 February 2017 at 17:55

Status:

Active

» Needs review

File	Size
2851239_2.patch	13.97 KB
thunder_tour.gif	8.52 MB

Attached patch improves existing tours a bit (more tips, rewording) and tries to lead the user from one to the other. It also adds a tour for the content listing page. Current sequence is: Homepage -> Content add form -> Paragraphs (content edit) -> Content listing.

I noticed two problems:

Tips hide below the admin toolbar (see homepage tour).
Links in tips are visually exactly the same as the rest of the text.

Both problems should be resolved by fixing core's CSS. I will open issues for that.

I was also thinking to remove "End tour" buttons on all steps as we want users to follow links to the next step. We could do that by overriding \Drupal\tour\TourViewBuilder. Thoughts?

Log in or register to post comments

Comment #3

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented 9 February 2017 at 19:43

There is already an issue for the z-index problem: #2851086: Tour tip display under toolbar

Log in or register to post comments

Comment #4

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented 9 February 2017 at 20:01

I created an issue for the link color problem: #2851270: Links in the tour tip body are visually the same as the rest of the text

Log in or register to post comments

Comment #5

chr.fritsch

he/him

German

🇩🇪🇪🇺🌍

CreditAttribution: chr.fritsch at Thunder commented 10 February 2017 at 09:00

Status:

Needs review

» Needs work

Yeah, i really like the improvements you did.

I would not completely remove the "End tour" button. I think it would be better, if the "End tour" button becomes a "Next tour" button.

Also it would be nice to have a "Previous" button, to step back.

Log in or register to post comments

Comment #6

chr.fritsch

he/him

German

🇩🇪🇪🇺🌍

CreditAttribution: chr.fritsch at Thunder commented 13 February 2017 at 08:14

Ok, i looked a bit in the tour module last week.

Looks like joyride doesn't provide a "Previous" button so far. We have to wait for a stable zurb/joyride 3.0 release. Then we could integrate that here: #2409861: Explore replacing obsolete Joyride asset with latest version. I am trying to figure out, when there will be a stable release.

Also it seems, that it's not that easy to overwrite the "End tour" button. So, for now i am fine with removing that button.