Problem/Motivation

Steps to reproduce

  1. Go to the block library for a non-default theme, i.e. /admin/structure/block/list/seven
  2. Disable a block by using the Disable dropbutton link
Expected result
You are still on the same page with the block now disabled
Actual result
While the block is disabled you are now on the block layout for the default theme, i.e. /admin/structure/block

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 interdiff-2851133-5-6.txt2.59 KBshadcn
#6 disabling_a_block-2851133-6.patch3.82 KBshadcn
#5 disabling_a_block-2851133-5-fail.patch1.12 KBshadcn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler created an issue. See original summary.

shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented
Assigned: Unassigned » shadcn

@tstoeckler OK if I take this? Doing some block related work right now.

shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented
Status: Active » Needs work

Looks like same is happening when removing a block.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented

@arshadcn Yes please. I do not intend to work on it, but I will review anything you post. Thanks!

shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented
Status: Needs work » Needs review
FileSize
disabling_a_block-2851133-5-fail.patch1.12 KB

Added tests to confirm this bug. Expected to fail.

shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented
FileSize
disabling_a_block-2851133-6.patch3.82 KB
interdiff-2851133-5-6.txt2.59 KB

Attaching the test and the fix. This adds the destination query to the operations.

The last submitted patch, 5: disabling_a_block-2851133-5-fail.patch, failed testing.

shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented

@tstoeckler this is ready for review. Thanks :)

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented

Thanks for the ping @arshadcn. I wanted to RTBC, but then I realized this may be duplicate of #2767857: Add destination to edit, delete, enable, disable links in entity list builders, which is a more generic solution. What do you think, since you have worked on this more closely? Maybe we can join efforts over there?

shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented

Yeah. Let's do that. Looks like there has been more activities there. Thanks.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Needs review » Closed (duplicate)
Related issues: +#2767857: Add destination to edit, delete, enable, disable links in entity list builders

Closing as a duplicate of #2767857: Add destination to edit, delete, enable, disable links in entity list builders