Comments

nileshlohar created an issue. See original summary.

nileshlohar’s picture

nileshlohar’s picture

Status: Active » Needs review
prafull.addweb’s picture

Hi nileshlohar ,Thanks! for the patch, but I think this change should also be applied for date.field.inc & theme.inc
Let me know your views on it.

Thanks.

prafull.addweb’s picture

Status: Needs review » Needs work
nileshlohar’s picture

Status: Needs work » Needs review

Thanks for the review @prafullpanchori !
but, i didnt found any other instances of it.
Please share if you find anyhting.

prafull.addweb’s picture

@nileshlohar,May be you are right, But i already mentioned 2 files above (date.field.inc & theme.inc)
in which change should be made.Let me know your views.

nileshlohar’s picture

@prafull.panchori - I didn't found anything in those 2 files (date.field.inc & theme.inc) as well.

prafull.addweb’s picture

@nileshlohar, Please check a portion of the file I added.
date.field.inc =>

   'format_interval' => array(
      'label' => t('Time ago'),
      'field types' => array('date', 'datestamp', 'datetime'),
      'settings' => array(
        'interval' => 2,
        'interval_display' => 'time ago',
        'use_end_date' => false,
      ),
    ),

theme.inc =>

function theme_date_time_ago($variables) {
  $start_date = $variables['start_date'];
  $end_date = $variables['end_date'];
  $use_end_date = isset($variables['use_end_date']) ? $variables['use_end_date'] : false;
  $interval = !empty($variables['interval']) ? $variables['interval'] : 2;
  $display = isset($variables['interval_display']) ? $variables['interval_display'] : 'time ago';

  // If no date is sent, then return nothing.
  if (empty($start_date) || empty($end_date)) {
    return;
  }
nileshlohar’s picture

@prafull.panchori - It seems you are not following latest code.
the code you posted in #9 is pretty outdated.

prafull.addweb’s picture

@nileshlohar,I'm using & Checked code from 7.x-2.x-dev version, and there is no new release happened to check the updated code.

AshwiniPatil’s picture

Here is the patch which takes care of other similar issues.

prafull.addweb’s picture

Status: Needs review » Reviewed & tested by the community

@AshwiniPatil,Thanks for the updated patch with changes as required.it works well

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 12: uppercase_php_constants-2851020-12.patch, failed testing.

rahul.nahar001’s picture

Status: Needs work » Needs review
FileSize
6.81 KB

Hi All,

Please find updated patch here.

Thanks

darshanchoudhary’s picture

Status: Needs review » Reviewed & tested by the community

@rahul.nahar001 I have successfully applied and tested the patch. Seems to be working fine.