We need to add this into the D8 module and the correct logic to accompany it.
Some questions and comments on source of ticket:
"What happens if the Source is EDITED and then a READY_INTERIM target gets downloaded? Is it fine that it stays as INTERIM? Because I feel like that tells me it is a current-source, in-progress target download, when in this situation it is really an edited-source, in-progress target download and I feel should be more in line with the styling of NOT_CURRENT/EDITED and not CURRENT.
I would propose adding another target status called INTERIM_NOT_CURRENT that would have the border and text colors being #FFC107."
Comment | File | Size | Author |
---|---|---|---|
#19 | interdiff-16-19.txt | 24.81 KB | mdahl328151 |
#19 | status_interim_not_current-2850547-19.patch | 40.12 KB | mdahl328151 |
#16 | interdiff-13-16.txt | 4.19 KB | mdahl328151 |
#16 | status_interim_not_current-2850547-16.patch | 29.42 KB | mdahl328151 |
| |||
#15 | status_interim_not_current-2850547-13.patch | 25.8 KB | mdahl328151 |
|
Comments
Comment #2
mdahl328151 CreditAttribution: mdahl328151 commentedThis patch should be applied after applying the patch from https://www.drupal.org/node/2850548.
Comment #3
penyaskito#2850548: STATUS_INTERIM_READY needs to be added to transition flow has tests, I think we could have similar tests here too.
Nickpick, but let's change this constant to 'INTERIM-EDITED'.
Comment #4
mdahl328151 CreditAttribution: mdahl328151 commentedComment #5
mdahl328151 CreditAttribution: mdahl328151 commentedSTATUS_INTERMEDIATE is misspelled
Comment #6
mdahl328151 CreditAttribution: mdahl328151 commentedComment #8
mdahl328151 CreditAttribution: mdahl328151 commentedComment #9
mdahl328151 CreditAttribution: mdahl328151 commentedComment #11
mdahl328151 CreditAttribution: mdahl328151 commentedComment #12
penyaskitoIs this change related?
I didn't review completely the rest of the patch but this wasn't expected.
Not sure why are we editing this test instead of having a new one.
Comment #13
mdahl328151 CreditAttribution: mdahl328151 commentedComment #15
mdahl328151 CreditAttribution: mdahl328151 commentedThis patch is the same as patch 15, but can be applied to branch 8.x-2.x
Comment #16
mdahl328151 CreditAttribution: mdahl328151 commentedAdded config tests
Comment #17
mdahl328151 CreditAttribution: mdahl328151 commentedFixed some whitespace and added more tests
Comment #19
mdahl328151 CreditAttribution: mdahl328151 commentedFixed some whitespace and added more tests
Comment #21
mdahl328151 CreditAttribution: mdahl328151 commented