Source and Target are set to Current when target is downloaded

I would love a test showing this bug, so we can ensure we are fixing it.

1. +++ b/src/LingotekConfigTranslationService.php
   @@ -509,11 +509,22 @@ class LingotekConfigTranslationService implements LingotekConfigTranslationServi
   +        // Deprecated  "|| $source_status == Lingotek::STATUS_EDITED" from
   +        // if statment because if the source status is EDITED then it has
   +        // not been uploaded again and so a target translation could be
   +        // ready for download and then be downloaded but the source remains
   +        // EDITED and should not be changed to CURRENT
   
   +++ b/src/LingotekContentTranslationService.php
   @@ -598,10 +598,21 @@ class LingotekContentTranslationService implements LingotekContentTranslationSer
   +            // Deprecated  "|| $source_status == Lingotek::STATUS_EDITED" from
   +            // if statment because if the source status is EDITED then it has
   +            // not been uploaded again and so a target translation could be
   +            // ready for download and then be downloaded but the source remains
   +            // EDITED and should not be changed to CURRENT
   +            if ($source_status == Lingotek::STATUS_IMPORTING) {
   

   I don't think we need these comments. We can add one in the if clause explaining the code, but IMHO we shouldn't explain code that we are removing.

2. +++ b/src/LingotekConfigTranslationService.php
   @@ -509,11 +509,22 @@ class LingotekConfigTranslationService implements LingotekConfigTranslationServi
   +        if ($source_status == Lingotek::STATUS_EDITED && $status) {
   +          $this->setTargetStatus($entity, $langcode, Lingotek::STATUS_EDITED);
   +        }
   +        elseif ($source_status == Lingotek::STATUS_EDITED && !$status) {
   +          $this->setTargetStatus($entity, $langcode, Lingotek::STATUS_EDITED);
   +        }
   
   +++ b/src/LingotekContentTranslationService.php
   @@ -598,10 +598,21 @@ class LingotekContentTranslationService implements LingotekContentTranslationSer
   +            if ($source_status == Lingotek::STATUS_EDITED && $status) {
   +              $this->setTargetStatus($entity, $langcode, Lingotek::STATUS_EDITED);
   +            }
   +            elseif ($source_status == Lingotek::STATUS_EDITED && !$status) {
   +              $this->setTargetStatus($entity, $langcode, Lingotek::STATUS_EDITED);
   +            }
   

   These ones could be simplified to

   if ($source_status == Lingotek::STATUS_EDITED)
   

   Do we need the same logic in downloadConfig()?

3. +++ b/src/Tests/LingotekNodeStatusDownloadTargetTest.php
   @@ -0,0 +1,133 @@
   +class LingotekNodeStatusDownloadTargetTest extends LingotekTestBase {
   

   We would need the same test for a config entity and a config object for ensuring that we have proper coverage. We are only covering content here, and we already had issues maintaining those in sync (at some point we should unify this logic and remove code duplication for content entities, config entities and config objects)

+++ b/src/Tests/LingotekNodeStatusDownloadTargetTest.php
@@ -0,0 +1,133 @@
+    $source_current = $this->xpath("//a[contains(@class,'language-icon') and contains(@class, 'source-current')  and contains(text(), 'EN')]");
+    $this->assertEqual(count($source_current), 0, 'Source is not marked as current.');
+    $es_current = $this->xpath("//a[contains(@class,'language-icon') and contains(@class, 'target-current')  and contains(text(), 'ES')]");
+    $this->assertEqual(count($es_current), 0, 'Spanish is not marked as current.');

Also, let's assert positively. Instead of asserting that the status is not current, let's assert for the status we actually expect it to be.

src/Tests/LingotekNodeStatusDownloadTargetTest.php already exists, so this patch doesn't apply anymore, could you reroll it?

I had this locally, I need to try again.

Splitting the patch for having one with only the tests, so ensures that we are adding coverage to this issue. Patch is exactly the same.

This looks good to me.

Committed 3d9564f and pushed to 8.x-2.x. Thanks!