Hi I have just updated this module and now I am getting this error:

The website encountered an unexpected error. Please try again later.
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "config_import.features_importer" has a dependency on a non-existent service "features.manager". in Symfony\Component\DependencyInjection\Compiler\CheckExceptionOnInvalidReferenceBehaviorPass->processReferences() (line 58 of /Users/leowoods/Sites/devdesktop/newsphere/vendor/symfony/dependency-injection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php).
Symfony\Component\DependencyInjection\Compiler\CheckExceptionOnInvalidReferenceBehaviorPass->processReferences(Array) (Line: 42)
Symfony\Component\DependencyInjection\Compiler\CheckExceptionOnInvalidReferenceBehaviorPass->processDefinition(Object) (Line: 36)
Symfony\Component\DependencyInjection\Compiler\CheckExceptionOnInvalidReferenceBehaviorPass->process(Object) (Line: 104)
Symfony\Component\DependencyInjection\Compiler\Compiler->compile(Object) (Line: 590)
Symfony\Component\DependencyInjection\ContainerBuilder->compile() (Line: 1263)
Drupal\Core\DrupalKernel->compileContainer() (Line: 866)
Drupal\Core\DrupalKernel->initializeContainer() (Line: 461)
Drupal\Core\DrupalKernel->boot() (Line: 651)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Any idea what I should do to fix it?

Thanks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

leovw created an issue. See original summary.

BR0kEN’s picture

Version: 8.x-1.2 » 8.x-1.x-dev
Assigned: Unassigned » BR0kEN
Priority: Normal » Critical
Status: Active » Needs review
FileSize
32.94 KB

Guys has created a release and used services from modules which were not added as dependencies to config_import.info.yml. Actually they shouldn't be added, because they are optional. New feature, presented in latest release, - features importer - its implementation is too raw and was not tested for now.

This patch solves the problem. New service will be added to DI container only when required modules (features and config_update) will be installed. Also I've added some tests for this.

Status: Needs review » Needs work

The last submitted patch, 2: confi-feature_importer_service-2850361-2.patch, failed testing.

BR0kEN’s picture

This related issue causes test fails.

BR0kEN’s picture

Status: Needs review » Needs work

Oops, it's happened accidentally.

BR0kEN’s picture

Status: Needs work » Needs review
FileSize
33.3 KB
629 bytes
BR0kEN’s picture

The same as #6, but with a bit improved code documentation.

The last submitted patch, 6: confi-feature_importer_service-2850361-6.patch, failed testing.

BR0kEN’s picture

Status: Needs review » Needs work

The last submitted patch, 9: confi-feature_importer_service-2850361-9.patch, failed testing.

BR0kEN’s picture

Status: Needs work » Needs review
FileSize
36.28 KB
2.43 KB

Fixed small inconsistency in tests.

BR0kEN’s picture

The last submitted patch, 11: confi-feature_importer_service-2850361-11.patch, failed testing.

BR0kEN’s picture

Status: Needs review » Needs work

The last submitted patch, 14: confi-feature_importer_service-2850361-14.patch, failed testing.

BR0kEN’s picture

The only fail - is an error from features module.

BR0kEN’s picture

  • BR0kEN committed d21523a on 8.x-1.x
    Issue #2850361 by BR0kEN, leovw: The service "config_import....
BR0kEN’s picture

Status: Needs review » Fixed
podarok’s picture

I was expecting to get 2 lines of code for info.yml file for dependencies.
Never saw such an over engineered patch so far.

For the testing we'll try the release in 2-3 months or so
Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.