JI QuickBooks Module

Aims to be a complete working solution for those that wish to save money and take advantage of automating common everyday tasks between a Drupal e-commerce store and QuickBooks - developed for QuickBooks Online.

Similar projects and how they are different

  • Commerce Quickbooks Online UI - is for Commerce, ours is for Ubercart. Also, ours syncs data as it becomes available directly to your QuickBooks Online account saving you time from having to hand enter customer, invoice, and payment data. Low dependencies: can be installed in less than five-ten minutes, apart from Ubercart module and the QBO SDK no other modules are required

Project page

Project Page

Git Command

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/Toshiwo/2847007.git ji_quickbooks
cd ji_quickbooks

Automatic Review

https://pareview.sh/node/953

background and experience with Drupal

We work mainly developing Drupal custom modules, but we also worked on themes (we plan to release a free theme soon).

Manual reviews of other projects

[D7] SSOXS (Single Sign On for eXternal Services)
https://www.drupal.org/node/2241681#comment-11919169

[D6] & [D7] Sur.ly
https://www.drupal.org/node/2374429#comment-11919268

[D7] Angular js example
https://www.drupal.org/node/2384917#comment-11919311

[D7] CKEditor Kaltura
https://www.drupal.org/node/2849450#comment-11919608

CommentFileSizeAuthor
#14 pareview_2850252.txt97.21 KBMario Steinitz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Toshiwo created an issue. See original summary.

Toshiwo’s picture

Issue summary: View changes
Toshiwo’s picture

Issue summary: View changes
PA robot’s picture

Issue summary: View changes
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxToshiwo2847007git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

JoshIdeas’s picture

Status: Needs work » Needs review

Hello friendly PA Robot,

1) We reviewed the errors/warnings from pareview.sh and didn't notice critical security issues or blockers.

JoshIdeas’s picture

Issue summary: View changes
jeetendrakumar’s picture

Status: Needs review » Needs work

@Joshldeas: There are many errors reported by automated review tools. Please fix these issues.

https://pareview.sh/node/953

JoshIdeas’s picture

Status: Needs work » Needs review

Besides the "functions should be prefixed..." messages for

/modules/ji_ubercart/ji_ubercart.module and
/modules/ji_customer/ji_customer.module

All errors have been cleaned.

JoshIdeas’s picture

Issue summary: View changes
JoshIdeas’s picture

Status: Needs review » Fixed

No longer need to wait for review! Marking this as closed and continued development will occur.

klausi’s picture

Status: Fixed » Needs review

I assume you still want this reviewed to get security team support?

JoshIdeas’s picture

Yes sir. That would be awesome. Thank you.

Toshiwo’s picture

RC1 just released:
https://www.drupal.org/project/ji_quickbooks/releases/7.x-1.0-rc1

Latest test does not report any coding standard issue:
https://www.drupal.org/pift-ci-job/647700

Mario Steinitz’s picture

Status: Needs review » Needs work
FileSize
97.21 KB

Well, please have a look to the current PAReview.sh results. I didn't want to add them as text within this post, as it would have been too long. Please fix the issues of this automated test before the next manual review.

Review of the 7.x-1.x branch (commit 1b061a3): https://www.drupal.org/files/issues/pareview_2850252.txt

JoshIdeas’s picture

Thank you Mario. It's good to see we're getting some attention. I'll review in the coming days.

JoshIdeas’s picture

Status: Needs work » Needs review

All white spaces have been removed.

apaderno’s picture

Status: Needs review » Needs work

Thank you for your contribution!

The project used for this application has 169 commits from another user. Since the application is done to estimate what the user who is applying understands about writing secure code and using Drupal coding standards, this project cannot be used for these applications.

To make it clearer: This application doesn't change the status of the project, but assigns a new role to the user who applies. It's a user application, not a project application.

JoshIdeas’s picture

At the rate at which Drupal's review process takes, it's becoming less and less important to apply. One of these days, I'll apply directly. Thank you for your time.

apaderno’s picture

Status: Needs work » Closed (won't fix)

If you are still interested on being able to opt into security coverage for projects you create, please open a new application using a project for which the only commits (for the time required to set the application's status to Fixed) are from you.
Please don't open a new application if you aren't sure to have time to dedicate to the application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.