This module provides a custom file field that renders a drop area that upload files directly to AWS S3 bucket using the Evaporate JS.

Project page:

https://www.drupal.org/sandbox/ljcarnieri/2835120

Repository:

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/ljcarnieri/2835120.git drop2s3

Automated Review Tool:

https://pareview.sh/node/970/repeat
http://git.drupal.org/sandbox/ljcarnieri/2835120.git

Comments

ljcarnieri created an issue. See original summary.

ljcarnieri’s picture

Issue summary: View changes
PA robot’s picture

Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

jeetendrakumar’s picture

Hi,

Please fix following issue:

FILE: /root/repos/pareviewsh/pareview_temp/drop2s3.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
37 | WARNING | Do not use drupal_add_js() in hook_init(), use #attached
| | for CSS and JS in your page/form callback or in
| | hook_page_build() instead
ljcarnieri’s picture

Thanks a lot @jeetendrakumar for your review.
I fixed the issue.

arunkumark’s picture

Status: Active » Needs work

@ljcarnieri

1. Variables not deleted.
The variables(drop2s3_awssdk2_secret_key, drop2s3_bucket, drop2s3_cache_presigned_url, ) used in this module need to delete on hook_uninstall()

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.