Back in Textimage 7.x-3.x there is an option to use the JQuery Colorpicker to select color in the image effects UI. When code was ported to D8 in this module, the JQuery Colorpicker module was not ported to D8 yet.

Now there is a stable release of JQuery Colorpicker, so we can re-add that option now, in form of an additional color selector plugin. We can also use some nice features of D8, and implementing a ModuleUninstallValidator service for this module, ensure that if the JQuery Colorpicker plugin is selected, then the JQuery Colorpicker module cannot be uninstalled.

CommentFileSizeAuthor
#4 2850131-4.patch11.86 KBmondrake
#4 interdiff_3-4.txt1.04 KBmondrake
#3 2850131-3.patch11.86 KBmondrake
#3 interdiff_2-3.txt1.84 KBmondrake
#2 2850131-2.patch10.02 KBmondrake
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2850131-2.patch10.02 KB
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
FileSize
interdiff_2-3.txt1.84 KB
2850131-3.patch11.86 KB

With a test to ensure the jquery_colorpicker module cannot be installed when the jquery_colorpicker plugin is in use by image_effects.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
FileSize
interdiff_3-4.txt1.04 KB
2850131-4.patch11.86 KB

Code style corrections, kudos at the new cody style check on the bots

  • mondrake committed 32d9e73 on 8.x-1.x 
    Issue #2850131 by mondrake: Add a JQuery Colorpicker color selector...
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.