Problem/Motivation

In #2847284: Display summary for behaviour plugins in closed form a setParagraphsWidgetMode() method has been created to help a test setting the condition needed to actually test something else.
This method will be used in other tests (see #2848443: Make all plugins return an array of the settings summary) as duplicated code.

Proposed resolution

As suggested in the related issue at the comment #9:

... move this method either in ParagraphsExperimentalTestBase or ParagraphsTestBase, so we can remove them from each single tests.

Let's just move it to ParagraphsTestBase. Then remove this method forom the other Paragraphs tests as well.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 move-2850050-5.patch8.49 KBVladimirMarko
#5 interdiff-2850050-3-5.txt5.01 KBVladimirMarko
#3 move-2850050-3.patch3.48 KBVladimirMarko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tduong created an issue. See original summary.

VladimirMarko’s picture

VladimirMarko CreditAttribution: VladimirMarko commented
Assigned: Unassigned » VladimirMarko
VladimirMarko’s picture

VladimirMarko CreditAttribution: VladimirMarko commented
Status: Active » Needs review
FileSize
move-2850050-3.patch3.48 KB

Moved setParagraphsWidgetMode from the "Classic" tests to ParagraphsTestBase as requested.

tduong’s picture

tduong CreditAttribution: tduong at MD Systems GmbH commented
Issue summary: View changes
Status: Needs review » Needs work

As discussed, remove setParagraphsWidgetMode() from the Paragraphs tests.

VladimirMarko’s picture

VladimirMarko CreditAttribution: VladimirMarko at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
interdiff-2850050-3-5.txt5.01 KB
move-2850050-5.patch8.49 KB

Now removed from the "Experimental" tests as well.

tduong’s picture

tduong CreditAttribution: tduong at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Alright for me :)

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

OK committed, thx. :-)

But be cautious with moving more things into the base. It's likely we will drop settings and add new ones in the Experimental widget.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.