Problem/Motivation
In #2847284: Display summary for behaviour plugins in closed form a setParagraphsWidgetMode()
method has been created to help a test setting the condition needed to actually test something else.
This method will be used in other tests (see #2848443: Make all plugins return an array of the settings summary) as duplicated code.
Proposed resolution
As suggested in the related issue at the comment #9:
... move this method either in ParagraphsExperimentalTestBase or ParagraphsTestBase, so we can remove them from each single tests.
Let's just move it to ParagraphsTestBase. Then remove this method forom the other Paragraphs tests as well.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#5 | move-2850050-5.patch | 8.49 KB | VladimirMarko |
#5 | interdiff-2850050-3-5.txt | 5.01 KB | VladimirMarko |
Comments
Comment #2
VladimirMarko CreditAttribution: VladimirMarko commentedComment #3
VladimirMarko CreditAttribution: VladimirMarko commentedMoved
setParagraphsWidgetMode
from the "Classic" tests toParagraphsTestBase
as requested.Comment #4
tduong CreditAttribution: tduong at MD Systems GmbH commentedAs discussed, remove setParagraphsWidgetMode() from the Paragraphs tests.
Comment #5
VladimirMarko CreditAttribution: VladimirMarko at MD Systems GmbH commentedNow removed from the "Experimental" tests as well.
Comment #6
tduong CreditAttribution: tduong at MD Systems GmbH commentedAlright for me :)
Comment #8
miro_dietikerOK committed, thx. :-)
But be cautious with moving more things into the base. It's likely we will drop settings and add new ones in the Experimental widget.