I installed the module and when going through the config screens I found the following on the search config screen:

Warning: include_once(/home/website/web/modules/taxonomy/taxonomy.admin.inc): failed to open stream: No such file or directory in include_once() (line 12 of modules/contrib/taxonomy_manager/taxonomy_manager.admin.inc).

include_once() (Line: 12)
require_once('/home/website/web/modules/contrib/taxonomy_manager/taxonomy_manager.admin.inc') (Line: 275)
Drupal\Core\Extension\ModuleHandler->loadInclude('taxonomy_manager', 'admin.inc', 'taxonomy_manager') (Line: 254)
Drupal\Core\Extension\ModuleHandler->loadAllIncludes('admin.inc') (Line: 174)
Drupal\search\SearchPageListBuilder->buildForm(Array, Object)
call_user_func_array(Array, Array) (Line: 514)
Drupal\Core\Form\FormBuilder->retrieveForm('search_admin_settings', Object) (Line: 271)
Drupal\Core\Form\FormBuilder->buildForm('search_admin_settings', Object) (Line: 212)
Drupal\Core\Form\FormBuilder->getForm(Object) (Line: 98)
Drupal\Core\Config\Entity\DraggableListBuilder->render() (Line: 22)
Drupal\Core\Entity\Controller\EntityListController->listing('search_page')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 574)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
call_user_func_array(Object, Array) (Line: 144)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 64)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 652)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Is that require something left over from the conversion?

CommentFileSizeAuthor
#4 delete_not_used_code-2849948-4.patch341 bytesalex_optim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Christopher Riley created an issue. See original summary.

Znak’s picture

Assigned: Unassigned » Znak
Status: Active » Postponed (maintainer needs more info)

This module is not correct porting to Drupal 8.

JacobSanford’s picture

Assigned: Znak » Unassigned

Related issues:

#2881618: Removed deprecated Database queries.
#2792761: taxonomy_vocabulary_load and taxonomy_vocabulary_load have been deprecated

This file looks to be legacy migration code that should not be used in the final 8.x, as admin forms are stored in src/Form and routes added in routing. Some of this functionality has been ported to the proper spot, but I'm reluctant to suggest removal of the file it until the maintainer weighs in.

alex_optim’s picture

Status: Postponed (maintainer needs more info) » Needs review
FileSize
341 bytes

File "taxonomy.admin.inc" not use in drupal 8.

JacobSanford’s picture

@alex_optim Thanks for your contribution! I was waiting for some input here before I removed some of this legacy cruft. In the interest of moving forward I think we should simply proceed. I'm going to merge this and make a meta issue that focuses on continuing to clean up the legacy code.

JacobSanford’s picture

Status: Needs review » Fixed
JacobSanford’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.