In the CommerceBaseTestCase class the site admin user created is not given the 'administer fields' permission but it is needed for tests which create the product display node and add fields. The CommerceProductReferenceAdminTest fails without that permission, for example.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swickham created an issue. See original summary.

swickham’s picture

Status: Active » Needs review
FileSize
429 bytes
mbreden’s picture

EDIT: Please ignore this patch, it's for the non-dev version (didn't realise this was for the dev branch).

mbreden’s picture

FileSize
688 bytes

EDIT: Please ignore this patch, it's for the non-dev version (didn't realise this was for the dev branch).

swickham’s picture

@mbreden, you weren't using the dev version of the module were you? The dev version should already have that permission assigned to the store admin. It looks like you've put up a patch for a released version of the module.

mbreden’s picture

The last submitted patch, 3: site_admin_user_in-2849841-3.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: site_admin_user_in-2849841-4.patch, failed testing.

rszrama’s picture

Assigned: swickham » Unassigned
Status: Needs work » Fixed

Committed the patch in #2.

  • rszrama committed acd2ba7 on 7.x-1.x authored by mbreden
    Issue #2849841 by swickham: grant the site admin user in tests the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.