Due to using a dev version with some table differences from other patches, I wanted to uninstall Commerce Shipping and then reinstall it with the current dev version.

In trying to do so, I noticed one of the configuration deletions it warns me about is that it's going to delete all of my checkout flows, presumably due to a required dependency on commerce_shipping being added from the shipping pane.

Is there a way to do this so that it simply updates the configuration of the checkout flows to remove the shipping pane information instead?

CommentFileSizeAuthor
#4 2849796-checkout-flow.patch2.54 KBbojanz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bmcclure created an issue. See original summary.

bmcclure’s picture

In my case I was able to alter my exported config to remove the shipping pane and commerce_shipping dependency from both my checkout flows, import the config, then uninstall commerce_shipping successfully. However it seems like a bug that it would have deleted it in the first place. If I get time I'll investigate how to resolve this, but for now just wanted to report it.

bojanz’s picture

Title: Checkout flows deleted when uninstalling Commerce Shipping » Stop defining a default_step for ShippingInformation, provide a custom checkout flow
Category: Bug report » Task
Priority: Normal » Major

We should not be adding the ShipmentInformation checkout pane to each checkout flow, it's wrong functionality-wise, and causes the config issue above.

bojanz’s picture

Status: Active » Needs review
FileSize
2.54 KB

Initial patch.

We also need to update the CheckoutPaneTest to use the "shipping" checkout flow (and remove the "shipping_test" one), cause it's been shown that testing without the PaymentInformation pane allows bugs to slip through.

Question:
Taking into account the setup steps in the README, would it be better to ship with our own order type, and tell people to edit their order item type to point to it?
I'm not convinced (1 step instead of 3), but it's worth asking.

bmcclure’s picture

Going to try and test this today. A couple of things in the meantime:

1. Does this mean that existing checkout flows can't be used with shipping? In my case I have two checkout flows, one for quotes and one for orders, however I still need to collect shipping profile information on quotes so that shipping can be quoted later. So currently I have the shipping information on both of my checkout flows. Will this still work going forward?

2. Is there a benefit to having a new order type instead of being able to use already-defined order types? IMO I like the concept of enhancing existing order types with shipping functionality rather than having a completely separate type, however there may very well be reasons for it that I don't currently understand.

bojanz’s picture

You are free to use existing checkout flows and order types, this is only about simplifying initial setup and not adding shipping info to each checkout flow without explicit admin action.

bmcclure’s picture

Thanks for the clarification! That makes a lot of sense in that case.

I personally don't think I would find a separate order type useful, however I can see where it might be in some cases; particularly for people just getting started with Commerce and Commerce Shipping to have fewer initial steps to get to a fully working state. However multiple order types existing by default once enabling Commerce and Commerce Shipping might also be confusing to some people (though I'm sure adequate documentation would cover that).

bojanz’s picture

Status: Needs review » Fixed

Agreed. Committed the patch as-is. Thanks for the feedback!

  • bojanz committed a4b8d9c on 8.x-2.x
    Issue #2849796 by bojanz, bmcclure: Stop defining a default_step for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.