One of the ideas rolling around in my head is an idea for a strict mode flag, a simple constant in settings.local.php. It would solve the problem of introducing error checking code or assertions that would break contrib modules. It would be used like this

function drupal_deprecated_function() {
  assert('!defined(\'DRUPAL_STRICT\') || FALSE');
}

Drupal would ship as normal and by default the definition of DRUPAL_STRICT would be commented out. Somehow the core tests would always run with DRUPAL_STRICT set. Contrib module authors would be encouraged, but not required, to develop modules with Strict on.

There are other possibilities this opens and touches on. Thoughts?

Comments

Aki Tendo created an issue. See original summary.

Aki Tendo’s picture

Aki Tendo CreditAttribution: Aki Tendo commented
Issue summary: View changes
cilefen’s picture

cilefen CreditAttribution: cilefen commented

See related #2575081: [policy, no patch] Use E_USER_DEPRECATED in Drupal 8 minor releases and #2488860: Bring phpunit bridge into drupal and use it for unit tests and simpletest to handle Deprecation.

Aki Tendo’s picture

Aki Tendo CreditAttribution: Aki Tendo commented
Related issues: +#2575081: [policy, no patch] Use E_USER_DEPRECATED in Drupal 8 minor releases
Aki Tendo’s picture

Aki Tendo CreditAttribution: Aki Tendo commented
Related issues: +#2488860: Bring phpunit bridge into drupal and use it for unit tests and simpletest to handle Deprecation
Aki Tendo’s picture

Aki Tendo CreditAttribution: Aki Tendo commented

While I used deprecated for the example and agree they are related, deprecated functionality is only part of the scope. Consider the following line I'd like to be able to put in the Drupal\Core\Template\Attribute class

protected function createAttributeValue($name, $value) {
  assert('!defined(\'DRUPAL_STRICT\') || Drupal\Core\Template\Attribute::validAttributeName($name));

The new function referenced there, validAttributeName, checks the passed name parameter against a regular expression based on the W3C's published guidelines on attribute names. In the unlikely event a contrib module is tossing in an invalid attribute name - say my?attribute - this assertion would fire and the code would break in dev. Since it's an assertion it would continue to run in prod, but that just forestalls an immediate disaster since most dev houses won't be too happy about needing to turn assertions off just to get a contrib module through tests.

So this has a slightly wider scope than just deprecation.

cilefen’s picture

cilefen CreditAttribution: cilefen commented

I know but they are similar notions.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: +DrupalCampNJ2017

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Issue tags: -Debugging +Debug

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.