Problem/Motivation

The validateBehaviorForm is not using a subform state for the behavior plugins, as the validateConfigurationForm is.
Check \Drupal\paragraphs\Form\ParagraphsTypeForm

          $subform_state = SubformState::createForSubform($form['behavior_plugins'][$id]['settings'], $form, $form_state);
          $behavior_plugin = $paragraphs_type->getBehaviorPlugin($id);
          $behavior_plugin->validateConfigurationForm($form['behavior_plugins'][$id]['settings'], $subform_state);

Proposed resolution

Use subform_state for the behavior plugins in validateBehaviorForm.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 behavior_subform_state-2849503-11.patch11.1 KBGinovski
#10 behavior_subform_state-2849503-10.patch11.57 KBGinovski
#10 interdiff-2849503-8-10.txt2.25 KBGinovski
#8 behavior_subform_state-2849503-8.patch11.01 KBGinovski
#4 use_subform_state_for-2849503-4.patch2.09 KBGinovski
#2 use_subform_state_for-2849503-2.patch1.15 KBGinovski
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ginovski created an issue. See original summary.

Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
Assigned: Unassigned » Ginovski
Status: Active » Needs review
FileSize
use_subform_state_for-2849503-2.patch1.15 KB

Added subform state

Status: Needs review » Needs work

The last submitted patch, 2: use_subform_state_for-2849503-2.patch, failed testing.

Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
use_subform_state_for-2849503-4.patch2.09 KB

Fixed test

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Looks fine but wondering if we don't want to do this for submit as well. I'm actually not sure why we don't and just pass in the $values. Unlike this, that would be an API change of course that would break plugins. But better now than later...

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

As discussed, lets do this here.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Priority: Normal » Critical

Let's get this in ASAP as it's breaking our contract.

Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
behavior_subform_state-2849503-8.patch11.01 KB

Changed the build/validate/submit behaviorForm arguments.

Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
Title: Use subform state for the validateBehaviorForm() » Use subform state for the BehaviorForm() functions
Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
FileSize
interdiff-2849503-8-10.txt2.25 KB
behavior_subform_state-2849503-10.patch11.57 KB

Changes in the form passing.

Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
FileSize
behavior_subform_state-2849503-11.patch11.1 KB

Removing unrelated change

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs review » Fixed

Committed, thx! Time to fix the Colllection! :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.