[D8] IBM Watson

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxtrangunghoa2846153git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello, trangunghoa!

As you may have noticed on the Comment #2, in order to have your module approved, you will have to evaluate the project of 3 other fellow programmers.

Well, I am on the same boat. I have submitted a Drupal 8 theme and need 3 Drupal.org members to evaluate it. I would appreciate if you could test it and give me your opinion. I promise to do the same for your project. Que-pro-quo! :)

Following is the link to my Drupal 8 Theme:
https://www.drupal.org/node/2829866

Hi trangunghoa,

I have reviewed your module. here is result:

https://pareview.sh/node/965

Manual Review

Individual user account
Yes, the guidelines">https://www.drupal.org/node/2765201">guidelines for individual user accounts.

No duplication
Yes, module duplication">https://www.drupal.org/node/23789">duplication and/or fragmentation.

Master Branch
Yes, the guidelines">https://www.drupal.org/node/1127732">guidelines for master branch.

Licensing
yes, the licensing">https://www.drupal.org/licensing/faq">licensing requirements.

3rd party assets/code
Yes, the guidelines">https://www.drupal.org/node/422996">guidelines for 3rd party assets/code.

README.txt/README.md
Yes, the guidelines">https://www.drupal.org/node/447604">guidelines for in-project documentation and/or the README">https://www.drupal.org/node/2181737">README Template.

Code long/complex enough for review
Yes, the guidelines">https://groups.drupal.org/node/195848">guidelines for project length and complexity.

Secure code
[Yes: Meets the security">https://www.drupal.org/writing-secure-code">security requirements. / No: List of security issues identified.]

Coding style & Drupal API usage

The project worked as well.

To the reviewers: Please change back the priority to Normal after doing a review.

Automated Review

Pareview details see: https://pareview.sh/pareview/https-git.drupal.org-project-ibm_watson.git...

Review of the 8.x-1.x branch (commit ef4a10a):

• Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
• The ibm_watson.module does not implement hook_help().
• DrupalPractice has found some issues with your code, but could be false positives.
• No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template: See pareview details

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) Login errors are not caught: GuzzleHttp\Exception\ClientException: Client error: `POST https://stream.watsonplatform.net/speech-to-text/api/v1/recognize?continuous=true&timestamps=true&model=en-US_BroadbandModel` resulted in a `401 Not Authorized` response: { "code" : 401 , "error" : "Not Authorized" , "description" : "2018-07-19T16:13:10-05:00, Error ERCDPLTFRM-DNLKUPERR occ (truncated...) in GuzzleHttp\Exception\RequestException::create() (line 113 of /home/dft6i/www/vendor/guzzlehttp/guzzle/src/Exception/RequestException.php). (Test account is not valid any more)
2. (*) Replace curl usage with GuzzleHttp\Client
3. (*) remove composer.lock from repository
4. (*) remove comments and datestamp from ibm_watson.info.yml, they are automatically appended
5. (*) remove guzzlehttp/guzzle from composer.json (and use GuzzleHttp\Client of drupal)
6. (*) remove route ibm_watson.example_description and the the controller WatsonExampleController.php
7. (*) remove password1 input in IbmWatsonSettingsForm because it is not used elsewhere

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.