Problem/Motivation
When trying setup my mapping i noticed that my number(integer) fields were not shown.
I checked the code and it seems that as well the Timestamp as Integer targets have the id 'integer'
To reproduce simply create a node that has at least 1 number (integer) field and try to map data on it in the feed mapping screen
you will notice the field will be missing from the target dropdown.
Proposed resolution
Change id of timestamp to timestamp. Also as a cleanup i removed the "created" and "timestamp" field_types from integer
as they are (now) available in timestamp and since timestamp seems to be a specialization if integer i doubt they are needed there.
User interface changes
None, but i can not figure out if this has potential inflence on already made mappings.
Data model changes
Maybe te removal of "created" and "timestamp" on Integer. And maybe the change of the id for timestamp.
I tested locally it seemed to work without problems.
Comment | File | Size | Author |
---|---|---|---|
#2 | feeds-number-fields-not-mappable-2849138-2.patch | 795 bytes | melvinlouwerse |
|
Comments
Comment #2
melvinlouwerse CreditAttribution: melvinlouwerse at Ibuildings commentedThe patch that will remove the duplicate id between timestamp and integer and clean up integer somewhat.
Comment #3
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedComment #5
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedTwo target plugins that having the same ID indeeds seems wrong.
Committed #2. Thanks for fixing!