Add handling of ConfigEvent::IMPORT_MISSING_CONTENT [#2849128]

Follow-up to #2833562-10: Installing modules using the ConfigImporter does not work

Problem/Motivation

There was introduced special event #2361423: Add a step to config import to allow contrib to create content based on config dependencies to handle missing content when config import finishing.
The parent issue allows to install default content fixtures for newly installed modules but in case of block content config it may need to import missing content entities instead of all module's default content

Proposed resolution

Add handling of the event to add missing content after config import

Remaining tasks

Reviews needed.

User interface changes

None

API changes

None

Comment	File	Size	Author
#2	2849128-config-import-2.patch	3.38 KB	andypost
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 4 pass

Issue fork default_content-2849128

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2849128-2.0.x changes, plain diff MR !39
Check out this branch
2849128-add-handling-of compare
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

2 February 2017 at 12:20

andypost created an issue. See original summary.

Comment #2

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 27 February 2017 at 12:23

Status:

Active

» Needs review

File	Size
2849128-config-import-2.patch	3.38 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 4 pass

Initial stub on it, discovery still needs proper implementation

Comment #3

tstoeckler

he/him

German

Essen, Germany

CreditAttribution: tstoeckler as a volunteer commented 27 February 2017 at 14:13

Status:

Needs review

» Needs work

+++ b/src/EventSubscriber/ConfigImportMissingContentEventSubscriber.php
@@ -0,0 +1,75 @@
+      $data['uuid'] . '.json',

I think this is problematic. While Default Content exports content with the .json filename by default, it supports renaming the files to something more semantic just fine.

As far as I can tell, the only way to reliably find the UUID is to actually parse the file.

Comment #4

basil_snowman CreditAttribution: basil_snowman as a volunteer and for Skilld commented 27 February 2017 at 16:30

Status:

Needs work

» Needs review

+++ b/src/EventSubscriber/ConfigImportMissingContentEventSubscriber.php
...
+  protected function doResolve($uuid, array $data) {
...
    /** @var \Drupal\default_content\DefaultContentManagerInterface $service */
+    $service = \Drupal::service('default_content.manager');
+    //$service->importContent($module, $uuid);
+    $service->importContent($path);

This construction does not work. Need change method importContent() into DefaultContentManager.

Comment #5

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 27 February 2017 at 18:43

I think we need to iterate only inside uuids that defined in module's info.yml "default_content" key

otoh it require to iterate over all modules and their files to find how many of exported files has this uuid inside, so could be disk intensive operation