As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#5 coding-standard-fix-2849091-5.patch13.95 KBurvashi_vora
#2 persiantools_2849091_1.patch2.24 KBnehakhadke

Issue fork persiantools-2849091

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke CreditAttribution: nehakhadke at Invezza Technologies commented
FileSize
persiantools_2849091_1.patch2.24 KB
urvashi_vora’s picture

urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commented
Assigned: Unassigned » urvashi_vora
urvashi_vora’s picture

urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commented

HI,

I reviewed your patch. It applied cleanly.

urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib/persiantools-2849091$ git apply -v persiantools_2849091_1.patch
Checking patch src/Form/PersianToolsAdminForm.php...
Checking patch src/RTLMaker.php...
Applied patch src/Form/PersianToolsAdminForm.php cleanly.
Applied patch src/RTLMaker.php cleanly.

But still, there are many errors.

Moving it to needs work.

Thanks

urvashi_vora’s picture

urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commented
Assigned: urvashi_vora » Unassigned
Status: Needs work » Needs review
FileSize
coding-standard-fix-2849091-5.patch13.95 KB

Hi,

Please review this patch.
Thanks